Issue 10066024: Convert chrome.experimental.alarms API to use IDL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10066024: Convert chrome.experimental.alarms API to use IDL. (Closed)

Created:
8 years, 8 months ago by Matt Perry

Modified:
8 years, 8 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert chrome.experimental.alarms API to use IDL. BUG=81758 TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132492

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -962 lines)			Patch
M	chrome/browser/extensions/extension_function_registry.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/common/common_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/api.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/common/extensions/api/experimental.alarms.idl	View	1 chunk	+67 lines, -0 lines	1 comment	Download
D	chrome/common/extensions/api/experimental.alarms.json	View	1 chunk	+0 lines, -116 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/common/extensions/docs/experimental.alarms.html	View	1 chunk	+0 lines, -833 lines	0 comments	Download
M	chrome/common/extensions/docs/js/api_page_generator.js	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

The IDL stuff works well enough to support the new alarms API now. The only ...

8 years, 8 months ago (2012-04-12 21:09:09 UTC) #1

asargent_no_longer_on_chrome

8 years, 8 months ago (2012-04-12 23:07:37 UTC) #2

LGTM

http://codereview.chromium.org/10066024/diff/1/chrome/common/extensions/api/e...
File chrome/common/extensions/api/experimental.alarms.idl (right):

http://codereview.chromium.org/10066024/diff/1/chrome/common/extensions/api/e...
chrome/common/extensions/api/experimental.alarms.idl:63: // Fired when an alarm
has expired. Useful for transient background pages.
nit: Using the word "expired" seems sort of misleading for repeating alarms,
because a repeating timer keeps firing onAlarm every |delayInSeconds| seconds
right? Would it be better to say something like "Fired for a timer after
delayInSeconds has elapsed"? Or perhaps "Dispatched when the timer with |name|
has fired."

Expand Messages | Collapse Messages