Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6208)

Unified Diff: chrome/common/extensions/extension.cc

Issue 10066014: Modify IsSyncable to only include Internal items and the Chrome Web Store (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 9e2ac3b960b9dda86cc5ff5029a76ffbf157d569..d30fa3c4f4ef31f4ba40453b7d443a61d2e181a4 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -3659,10 +3659,10 @@ Extension::SyncType Extension::GetSyncType() const {
bool Extension::IsSyncable() const {
// TODO(akalin): Figure out if we need to allow some other types.
- // We want to sync any extensions that are shown in the launcher because
- // their positions should sync.
+ // We want to sync any extensions that are internal and should appear on
+ // multiple machines, and the chrome web store.
Finnur 2012/04/12 15:01:40 nit: 'and should appear on multiple machines' is e
csharp 2012/04/12 15:06:29 Done.
return location() == Extension::INTERNAL ||
- ShouldDisplayInLauncher();
+ id() == extension_misc::kWebStoreAppId;
}
bool Extension::ShouldDisplayInLauncher() const {
« no previous file with comments | « no previous file | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698