Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: src/regexp.js

Issue 10066011: Regexp: Fix rightContext in the lastMatchInfoOverride case. (Closed) Base URL: http://v8.googlecode.com/svn/branches/3.2/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/version.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 346
347 function RegExpGetRightContext() { 347 function RegExpGetRightContext() {
348 var start_index; 348 var start_index;
349 var subject; 349 var subject;
350 if (!lastMatchInfoOverride) { 350 if (!lastMatchInfoOverride) {
351 start_index = lastMatchInfo[CAPTURE1]; 351 start_index = lastMatchInfo[CAPTURE1];
352 subject = LAST_SUBJECT(lastMatchInfo); 352 subject = LAST_SUBJECT(lastMatchInfo);
353 } else { 353 } else {
354 var override = lastMatchInfoOverride; 354 var override = lastMatchInfoOverride;
355 subject = override[override.length - 1]; 355 subject = override[override.length - 1];
356 start_index = override[override.length - 2] + subject.length; 356 var pattern = override[override.length - 3];
357 start_index = override[override.length - 2] + pattern.length;
357 } 358 }
358 return SubString(subject, start_index, subject.length); 359 return SubString(subject, start_index, subject.length);
359 } 360 }
360 361
361 362
362 // The properties $1..$9 are the first nine capturing substrings of the last 363 // The properties $1..$9 are the first nine capturing substrings of the last
363 // successful match, or ''. The function RegExpMakeCaptureGetter will be 364 // successful match, or ''. The function RegExpMakeCaptureGetter will be
364 // called with indices from 1 to 9. 365 // called with indices from 1 to 9.
365 function RegExpMakeCaptureGetter(n) { 366 function RegExpMakeCaptureGetter(n) {
366 return function() { 367 return function() {
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 %DefineAccessor($RegExp, "$'", SETTER, NoOpSetter, DONT_ENUM | DONT_DELETE); 475 %DefineAccessor($RegExp, "$'", SETTER, NoOpSetter, DONT_ENUM | DONT_DELETE);
475 476
476 for (var i = 1; i < 10; ++i) { 477 for (var i = 1; i < 10; ++i) {
477 %DefineAccessor($RegExp, '$' + i, GETTER, RegExpMakeCaptureGetter(i), DONT_D ELETE); 478 %DefineAccessor($RegExp, '$' + i, GETTER, RegExpMakeCaptureGetter(i), DONT_D ELETE);
478 %DefineAccessor($RegExp, '$' + i, SETTER, NoOpSetter, DONT_DELETE); 479 %DefineAccessor($RegExp, '$' + i, SETTER, NoOpSetter, DONT_DELETE);
479 } 480 }
480 } 481 }
481 482
482 483
483 SetupRegExp(); 484 SetupRegExp();
OLDNEW
« no previous file with comments | « no previous file | src/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698