Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 10065041: Fix flakiness in unload browser test, take two. I was able to repro this on my Linux box (~10% of t… (Closed)

Created:
8 years, 8 months ago by jam
Modified:
8 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews
Visibility:
Public.

Description

Fix flakiness in unload browser test, take two. I was able to repro this on my Linux box (~10% of the time). The issue turned out to be that the beforeunload ack from the renderer would sometimes come after the second time that we try to close the tab. The browser wouldn't put up the beforeunload prompt because it was waiting for the previous ack. The old ui test had a 10 second sleep here which masked this. BUG=123110 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132217

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M chrome/browser/unload_browsertest.cc View 4 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 8 months ago (2012-04-13 17:55:07 UTC) #1
eroman
8 years, 8 months ago (2012-04-13 18:31:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698