fix dnd in bookmark manager

fix dnd in bookmark manager

preventDefault in handleDrop, as suggested by arv

BUG=122850
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132203

[dcheng, 2012-04-13 03:22:03]

lgtm

[commit-bot: I haz the power, 2012-04-13 03:38:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10065034/1

[commit-bot: I haz the power, 2012-04-13 03:38:07]

Presubmit check for 10065034-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/bookmark_manager/js/main.js:
  line 5: Use var instead of const.
const BookmarkList = bmm.BookmarkList;
^^^^^
  line 6: Use var instead of const.
const BookmarkTree = bmm.BookmarkTree;
^^^^^
  line 7: Use var instead of const.
const ListItem = cr.ui.ListItem;
^^^^^
  line 8: Use var instead of const.
const TreeItem = cr.ui.TreeItem;
^^^^^
  line 9: Use var instead of const.
const LinkKind = cr.LinkKind;
^^^^^
  line 10: Use var instead of const.
const Command = cr.ui.Command;
^^^^^
  line 11: Use var instead of const.
const CommandBinding = cr.ui.CommandBinding;
^^^^^
  line 12: Use var instead of const.
const Menu = cr.ui.Menu;
^^^^^
  line 13: Use var instead of const.
const MenuButton  = cr.ui.MenuButton;
^^^^^
  line 14: Use var instead of const.
const Promise = cr.Promise;
^^^^^
  line 48: Use var instead of const.
const ROOT_ID = '0';
^^^^^
  line 13: E0001: Extra space after "MenuButton"
const MenuButton  = cr.ui.MenuButton;
                ^^
  line 39: E0010: Missing semicolon at end of line
    searchTreeItem.icon = 'images/bookmark_manager_search.png'
                                                             ^
  line 41: E0010: Missing semicolon at end of line
    searchTreeItem.icon = 'images/bookmark_manager_search_rtl.png'
                                                                 ^
  line 55: E0220: No docs found for member
'splitter.previousElementSibling.style.width'
  splitter.previousElementSibling.style.width = localStorage['treeWidth'];
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 196: E0012: Illegal semicolon after function declaration
};
 ^
  line 200: E0220: No docs found for member 'window.onhashchange'
window.onhashchange = function(e) {
^^^^^^^^^^^^^^^^^^^
  line 223: E0200: Invalid JsDoc tag: para
 * @para {string} searchText The text to search for.
   ^^^^^
  line 225: E0210: Missing docs for parameter: "searchText"
function setSearch(searchText) {
                             ^^
  line 309: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 326: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 344: E0217: Missing @return JsDoc in function with non-trivial return
   */
   ^^
  line 370: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 394: E0217: Missing @return JsDoc in function with non-trivial return
   */
   ^^
  line 416: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 445: E0217: Missing @return JsDoc in function with non-trivial return
   */
   ^^
  line 467: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 482: E0217: Missing @return JsDoc in function with non-trivial return
   */
   ^^
  line 648: E0010: Missing semicolon at end of line
        rect.width -= rect.left
                      ^^^^^^^^^
  line 549: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 686: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 716: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 816: E0220: No docs found for member 'list.contextMenu'
list.contextMenu = $('context-menu');
^^^^^^^^^^^^^^^^
  line 817: E0220: No docs found for member 'tree.contextMenu'
tree.contextMenu = $('context-menu');
^^^^^^^^^^^^^^^^
  line 824: E0220: No docs found for member 'command.disabled'
    command.disabled = true;
    ^^^^^^^^^^^^^^^^

Presubmit checks took 1.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[arv (Not doing code reviews), 2012-04-13 04:19:06]

LGTM

[Melecka.Monika, 2014-06-23 06:03:21]

On 2012/04/13 04:19:06, arv wrote:
> LGTM