Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/history/history_backend_unittest.cc

Issue 10060003: Support for different weight-functions for time-slicing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added missing #include Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_backend.cc ('k') | chrome/browser/history/visit_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend_unittest.cc
diff --git a/chrome/browser/history/history_backend_unittest.cc b/chrome/browser/history/history_backend_unittest.cc
index d3f6f0b5e2d14da33fcedd6f1fb99677ebb0c3ea..f6fe159e52969bc09b5bcd92c942890c60e31b33 100644
--- a/chrome/browser/history/history_backend_unittest.cc
+++ b/chrome/browser/history/history_backend_unittest.cc
@@ -610,7 +610,7 @@ TEST_F(HistoryBackendTest, KeywordGenerated) {
// But no visible visits.
visits.clear();
backend_->db()->GetVisibleVisitsInRange(base::Time(), base::Time(), 1,
- &visits);
+ &visits, true);
EXPECT_TRUE(visits.empty());
// Expire the visits.
@@ -1255,6 +1255,7 @@ TEST_F(HistoryBackendTest, QueryFilteredURLs) {
Time tested_time = Time::Now().LocalMidnight() +
base::TimeDelta::FromHours(4);
base::TimeDelta half_an_hour = base::TimeDelta::FromMinutes(30);
+ base::TimeDelta one_hour = base::TimeDelta::FromHours(1);
base::TimeDelta one_day = base::TimeDelta::FromDays(1);
const content::PageTransition kTypedTransition =
@@ -1317,8 +1318,8 @@ TEST_F(HistoryBackendTest, QueryFilteredURLs) {
VisitFilter filter;
// Time limit is |tested_time| +/- 45 min.
base::TimeDelta three_quarters_of_an_hour = base::TimeDelta::FromMinutes(45);
- filter.SetTimeInRangeFilter(tested_time - three_quarters_of_an_hour,
- tested_time + three_quarters_of_an_hour);
+ filter.SetFilterTime(tested_time);
+ filter.SetFilterWidth(three_quarters_of_an_hour);
backend_->QueryFilteredURLs(request1, 100, filter);
ASSERT_EQ(4U, get_filtered_list().size());
@@ -1336,8 +1337,8 @@ TEST_F(HistoryBackendTest, QueryFilteredURLs) {
base::Unretained(static_cast<HistoryBackendTest*>(this))));
cancellable_request.MockScheduleOfRequest<QueryFilteredURLsRequest>(
request2);
- filter.SetTimeInRangeFilter(tested_time,
- tested_time + base::TimeDelta::FromHours(2));
+ filter.SetFilterTime(tested_time + one_hour);
+ filter.SetFilterWidth(one_hour);
backend_->QueryFilteredURLs(request2, 100, filter);
ASSERT_EQ(3U, get_filtered_list().size());
@@ -1352,8 +1353,8 @@ TEST_F(HistoryBackendTest, QueryFilteredURLs) {
base::Unretained(static_cast<HistoryBackendTest*>(this))));
cancellable_request.MockScheduleOfRequest<QueryFilteredURLsRequest>(
request3);
- filter.SetTimeInRangeFilter(tested_time - base::TimeDelta::FromHours(2),
- tested_time);
+ filter.SetFilterTime(tested_time - one_hour);
+ filter.SetFilterWidth(one_hour);
backend_->QueryFilteredURLs(request3, 100, filter);
ASSERT_EQ(3U, get_filtered_list().size());
@@ -1373,8 +1374,8 @@ TEST_F(HistoryBackendTest, QueryFilteredURLs) {
base::Unretained(static_cast<HistoryBackendTest*>(this))));
cancellable_request.MockScheduleOfRequest<QueryFilteredURLsRequest>(
request4);
- filter.SetDayOfTheWeekFilter(static_cast<int>(exploded_time.day_of_week),
- tested_time);
+ filter.SetFilterTime(tested_time);
+ filter.SetDayOfTheWeekFilter(static_cast<int>(exploded_time.day_of_week));
backend_->QueryFilteredURLs(request4, 100, filter);
ASSERT_EQ(2U, get_filtered_list().size());
@@ -1389,8 +1390,8 @@ TEST_F(HistoryBackendTest, QueryFilteredURLs) {
base::Unretained(static_cast<HistoryBackendTest*>(this))));
cancellable_request.MockScheduleOfRequest<QueryFilteredURLsRequest>(
request5);
- filter.SetTimeInRangeFilter(tested_time - base::TimeDelta::FromHours(1),
- tested_time - base::TimeDelta::FromMinutes(20));
+ filter.SetFilterTime(tested_time - base::TimeDelta::FromMinutes(40));
+ filter.SetFilterWidth(base::TimeDelta::FromMinutes(20));
backend_->QueryFilteredURLs(request5, 100, filter);
ASSERT_EQ(1U, get_filtered_list().size());
« no previous file with comments | « chrome/browser/history/history_backend.cc ('k') | chrome/browser/history/visit_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698