Support array types for function and callback arguments in IDL APIs.

Support array types for function and callback arguments in IDL APIs.

I realized we completely omitted array support with our initial IDl work. This
patch fixes that for 2 important cases, but doesn't yet add it in for 
dictionary members (that can be a separate patch).

BUG=122875
TEST=Included unit tests should pass


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132023

[miket_OOO, 2012-04-12 15:21:34]

lgtm

Great!

[commit-bot: I haz the power, 2012-04-12 15:48:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/10054039/2001

[commit-bot: I haz the power, 2012-04-12 18:39:30]

Change committed as 132023

[Matt Perry, 2012-04-12 18:56:53]

http://codereview.chromium.org/10054039/diff/2001/tools/json_schema_compiler/...
File tools/json_schema_compiler/idl_schema.py (right):

http://codereview.chromium.org/10054039/diff/2001/tools/json_schema_compiler/...
tools/json_schema_compiler/idl_schema.py:145: result = refs[self.typeref]
What is this code path used for? Doesn't this miss the array case? It seems like
for an array, we should do properties['items'] = refs[self.typeref]

[asargent_no_longer_on_chrome, 2012-04-12 23:14:24]

On 2012/04/12 18:56:53, Matt Perry wrote:
>
http://codereview.chromium.org/10054039/diff/2001/tools/json_schema_compiler/...
> File tools/json_schema_compiler/idl_schema.py (right):
> 
>
http://codereview.chromium.org/10054039/diff/2001/tools/json_schema_compiler/...
> tools/json_schema_compiler/idl_schema.py:145: result = refs[self.typeref]
> What is this code path used for? Doesn't this miss the array case? It seems
like
> for an array, we should do properties['items'] = refs[self.typeref]

Nice catch - thanks for the eagle eyes! It happens to work in most cases because
this 'refs' mechanism is only used for callbacks, but I think you are right that
this is a bug for that case. I'm looking into creating a test to demonstrate the
problem, and will then create a patch to fix it.

[asargent_no_longer_on_chrome, 2012-04-12 23:52:28]

On 2012/04/12 23:14:24, Antony Sargent wrote:
> On 2012/04/12 18:56:53, Matt Perry wrote:
> >
>
http://codereview.chromium.org/10054039/diff/2001/tools/json_schema_compiler/...
> > File tools/json_schema_compiler/idl_schema.py (right):
> > 
> >
>
http://codereview.chromium.org/10054039/diff/2001/tools/json_schema_compiler/...
> > tools/json_schema_compiler/idl_schema.py:145: result = refs[self.typeref]
> > What is this code path used for? Doesn't this miss the array case? It seems
> like
> > for an array, we should do properties['items'] = refs[self.typeref]
> 
> Nice catch - thanks for the eagle eyes! It happens to work in most cases
because
> this 'refs' mechanism is only used for callbacks, but I think you are right
that
> this is a bug for that case. I'm looking into creating a test to demonstrate
the
> problem, and will then create a patch to fix it.

To be more clear, I think this would break in the case where you wanted to have
an array of callbacks, e.g.

callback MyCallback = void(long x);
static void foo(MyCallback[] callback_list);