Correctly map list markers to a specific role rather than a generic group on Mac.

Correctly map list markers to a specific role rather than a generic group on Mac.


BUG=122238
TEST=manually with VoiceOver.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132231

[David Tseng, 2012-04-12 03:31:46]

On 4/11/12, dtseng@chromium.org <dtseng@chromium.org> wrote:
> Reviewers: Dominic Mazzoni,
>
> Description:
> Correctly map list markers to a specific role rather than a generic group on
> Mac.
>
>
> BUG=122238
> TEST=manually with VoiceOver.
>
>
> Please review this at https://chromiumcodereview.appspot.com/10054037/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>    M content/browser/accessibility/browser_accessibility_cocoa.mm
>
>
> Index: content/browser/accessibility/browser_accessibility_cocoa.mm
> diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm
> b/content/browser/accessibility/browser_accessibility_cocoa.mm
> index
>
353499c9480019fbc7a0527b107647fff67ebfe5..211e954be0ed69d48a01186a8a9a7e20e6f92723
>
> 100644
> --- a/content/browser/accessibility/browser_accessibility_cocoa.mm
> +++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
> @@ -138,7 +138,7 @@ RoleMap BuildRoleMap() {
>       { WebAccessibility::ROLE_LINK, NSAccessibilityLinkRole },
>       { WebAccessibility::ROLE_LIST, NSAccessibilityListRole },
>       { WebAccessibility::ROLE_LIST_ITEM, NSAccessibilityGroupRole },
> -    { WebAccessibility::ROLE_LIST_MARKER, NSAccessibilityGroupRole },
> +    { WebAccessibility::ROLE_LIST_MARKER, @"AXListMarker" },
>       { WebAccessibility::ROLE_LISTBOX, NSAccessibilityListRole },
>       { WebAccessibility::ROLE_LISTBOX_OPTION, NSAccessibilityGroupRole },
>       { WebAccessibility::ROLE_LOG, NSAccessibilityGroupRole },
>
>
>

[dmazzoni, 2012-04-12 03:39:09]

Could you add a dump_accessibility_tree test to go with it?

It's fine to skip the Windows expectations...

[David Tseng, 2012-04-12 17:14:32]

On 4/11/12, dmazzoni@chromium.org <dmazzoni@chromium.org> wrote:
> Could you add a dump_accessibility_tree test to go with it?
>
Done. Fairly similar to ul.html besides adding more complex in-line
elements inside a list item.

> It's fine to skip the Windows expectations...

Done.

[David Tseng, 2012-04-12 19:03:54]

PTAL; made changes for win as discussed.

On 4/12/12, David Tseng <dtseng@chromium.org> wrote:
> On 4/11/12, dmazzoni@chromium.org <dmazzoni@chromium.org> wrote:
>> Could you add a dump_accessibility_tree test to go with it?
>>
> Done. Fairly similar to ul.html besides adding more complex in-line
> elements inside a list item.
>
>> It's fine to skip the Windows expectations...
>
> Done.
>

[dmazzoni, 2012-04-12 21:23:42]

lgtm

[commit-bot: I haz the power, 2012-04-13 16:32:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtseng@chromium.org/10054037/11001

[commit-bot: I haz the power, 2012-04-13 19:03:00]

Change committed as 132231