Allow extension APIs to be restricted to a subset of Chrome channels using the

chrome/common/extensions/feature.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_FEATURE_H_
 #define CHROME_COMMON_EXTENSIONS_FEATURE_H_
 #pragma once
 
 #include <set>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
+#include "chrome/common/chrome_version_info.h"
 #include "chrome/common/extensions/extension.h"
 
 namespace extensions {
 
 // Represents a single feature accessible to an extension developer, such as a
 // top-level manifest key, a permission, or a programmatic API. A feature can
 // express requirements for where it can be accessed, and supports testing
 // support for those requirements.
 class Feature {
  public:
@@ skipping 31 matching lines @@
   enum Availability {
     IS_AVAILABLE,
     NOT_FOUND_IN_WHITELIST,
     INVALID_TYPE,
     INVALID_CONTEXT,
     INVALID_LOCATION,
     INVALID_PLATFORM,
     INVALID_MIN_MANIFEST_VERSION,
     INVALID_MAX_MANIFEST_VERSION,
     NOT_PRESENT,
-    DEPENDENCY_NOT_PRESENT
+    DEPENDENCY_NOT_PRESENT,
+    UNSUPPORTED_CHANNEL,
   };
 
   Feature();
   Feature(const Feature& other);
   virtual ~Feature();
 
+  // Sets the Channel to compare against. This will be initialized as
+  // chrome::VersionInfo::GetChannel(), which is fine for all but testing
+  // purposes.
+  void SetChannelForTesting(chrome::VersionInfo::Channel channel);
+
   const std::string& name() const { return name_; }
   void set_name(const std::string& name) { name_ = name; }
 
   // Gets the platform the code is currently running on.
   static Platform GetCurrentPlatform();
 
   // Gets the Feature::Location value for the specified Extension::Location.
   static Location ConvertLocation(Extension::Location extension_location);
 
   std::set<std::string>* whitelist() { return &whitelist_; }
@@ skipping 59 matching lines @@
   // members the same way: it matches everything. It is up to the higher level
   // code that reads Features out of static data to validate that data and set
   // sensible defaults.
   std::set<std::string> whitelist_;
   std::set<Extension::Type> extension_types_;
   std::set<Context> contexts_;
   Location location_;  // we only care about component/not-component now
   Platform platform_;  // we only care about chromeos/not-chromeos now
   int min_manifest_version_;
   int max_manifest_version_;
+
+  // The Channel to compare against |supported_channel_|.  Mutable for unit
+  // tests, usually this is just chrome::VersionInfo::GetChannel().
+  chrome::VersionInfo::Channel channel_;

[Aaron Boodman, 2012/04/11 23:35:53]

Sucks to have a separate value here for every single instance just to support
the testing case.

Can we make this test value be static instead?

[not at google - send to devlin, 2012/04/12 00:05:21]

Yeah, nicer.

+
+  chrome::VersionInfo::Channel supported_channel_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_FEATURE_H_