Add more diagnostic tracing when a JSON call doesn't return.

Add more diagnostic tracing when a JSON call doesn't return.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132282

[Nirnimesh, 2012-04-12 23:04:07]

I like that this CL differentiates between hung vs crashed browser.
I don't like hooking it into GetBrowserInfo. I've added a suggestion below

https://chromiumcodereview.appspot.com/10053019/diff/5001/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10053019/diff/5001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:1008: 'is possible this hook is broken.'
add a name to the hook: cmd_dict.get('command')

https://chromiumcodereview.appspot.com/10053019/diff/5001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:1633: def GetBrowserInfo(self,
performing_diagnostics=False):
I don't like that you're picking between the 2 methods, based on this flag. I
think you should leave this as-is, and..
1. Make your new diagnostic function be a wrapper around
_GetResultFromJSONRequest() and force it to call with cmd_dict {'command':
'GetBrowserInfo', 'windex': 0}

https://chromiumcodereview.appspot.com/10053019/diff/5001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:1725:
self._GetResultFromJSONRequestDiagnostics(cmd_dict, windex=None)
return the output of this call

[krisr, 2012-04-13 18:23:36]

PTAL

On Thu, Apr 12, 2012 at 4:04 PM, <nirnimesh@chromium.org> wrote:

> I like that this CL differentiates between hung vs crashed browser.
> I don't like hooking it into GetBrowserInfo. I've added a suggestion below
>
>
> https://chromiumcodereview.**appspot.com/10053019/diff/**
>
5001/chrome/test/pyautolib/**pyauto.py<https://chromiumcodereview.appspot.com/10053019/diff/5001/chrome/test/pyautolib/pyauto.py>
> File chrome/test/pyautolib/pyauto.**py (right):
>
> https://chromiumcodereview.**appspot.com/10053019/diff/**
>
5001/chrome/test/pyautolib/**pyauto.py#newcode1008<https://chromiumcodereview.appspot.com/10053019/diff/5001/chrome/test/pyautolib/pyauto.py#newcode1008>
> chrome/test/pyautolib/pyauto.**py:1008: 'is possible this hook is broken.'
> add a name to the hook: cmd_dict.get('command')
>
>
This is still included in the final message.


> https://chromiumcodereview.**appspot.com/10053019/diff/**
>
5001/chrome/test/pyautolib/**pyauto.py#newcode1633<https://chromiumcodereview.appspot.com/10053019/diff/5001/chrome/test/pyautolib/pyauto.py#newcode1633>
> chrome/test/pyautolib/pyauto.**py:1633: def GetBrowserInfo(self,
> performing_diagnostics=False):
> I don't like that you're picking between the 2 methods, based on this
> flag. I think you should leave this as-is, and..
> 1. Make your new diagnostic function be a wrapper around
> _GetResultFromJSONRequest() and force it to call with cmd_dict
> {'command': 'GetBrowserInfo', 'windex': 0}
>
>
Done


> https://chromiumcodereview.**appspot.com/10053019/diff/**
>
5001/chrome/test/pyautolib/**pyauto.py#newcode1725<https://chromiumcodereview.appspot.com/10053019/diff/5001/chrome/test/pyautolib/pyauto.py#newcode1725>
> chrome/test/pyautolib/pyauto.**py:1725:
> self._**GetResultFromJSONRequestDiagno**stics(cmd_dict, windex=None)
> return the output of this call
>
>
Obsolete


>
https://chromiumcodereview.**appspot.com/10053019/<https://chromiumcodereview...
>

[Nirnimesh, 2012-04-13 18:28:04]

LGTM

https://chromiumcodereview.appspot.com/10053019/diff/8001/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10053019/diff/8001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:938: def
_GetResultFromJSONRequestDiagnostics(self):
nit: need a blank line before this