Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 10053017: Request text context in the plugin process (Closed)

Created:
8 years, 8 months ago by brettw
Modified:
8 years, 8 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Make the text input not require round-trips when the text is updated. In the proxied version, this requests the text in-process avoiding the round trip. This also makes the requesting not reenter the plugin for in-process plugins. TEST= BUG=123020 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132027

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -24 lines) Patch
M ppapi/proxy/ppapi_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_text_input_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_text_input_proxy.cc View 4 chunks +33 lines, -11 lines 0 comments Download
M ppapi/shared_impl/ppb_instance_shared.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_instance_shared.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 3 chunks +3 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
LGTM with spelling nit. http://codereview.chromium.org/10053017/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right): http://codereview.chromium.org/10053017/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.cc#newcode611 webkit/plugins/ppapi/ppapi_plugin_instance.cc:611: // refcounted because we don't ...
8 years, 8 months ago (2012-04-11 23:37:14 UTC) #1
kinaba
LGTM (verified that IME keeps working with this patch), thanks. On 2012/04/11 23:37:14, viettrungluu wrote: ...
8 years, 8 months ago (2012-04-12 01:36:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/10053017/6002
8 years, 8 months ago (2012-04-12 18:24:35 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-12 18:28:55 UTC) #4
Try job failure for 10053017-6002 on android for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698