Add fast paths for Smi values in the dart embedding api.

vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/bitmap.h"
 #include "vm/dart.h"
 #include "vm/globals.h"
 #include "vm/handles.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
 #include "vm/os.h"
 #include "vm/raw_object.h"
 #include "vm/scanner.h"
 
 namespace dart {
 
 // Forward declarations.
 #define DEFINE_FORWARD_DECLARATION(clazz)                                      \
   class clazz;
 CLASS_LIST(DEFINE_FORWARD_DECLARATION)
 #undef DEFINE_FORWARD_DECLARATION
+class Api;
 class Assembler;
 class Code;
 class LocalScope;
 
 #define OBJECT_IMPLEMENTATION(object, super)                                   \
  public:  /* NOLINT */                                                         \
   Raw##object* raw() const { return reinterpret_cast<Raw##object*>(raw_); }    \
   void operator=(Raw##object* value) {                                         \
     initializeHandle(this, value);                                             \
   }                                                                            \
@@ skipping 2692 matching lines @@
   static RawClass* Class();
 
   static intptr_t Value(RawSmi* raw_smi) {
     return ValueFromRaw(reinterpret_cast<uword>(raw_smi));
   }
 
   static intptr_t RawValue(intptr_t value) {
     return reinterpret_cast<intptr_t>(New(value));
   }
 
-  static bool IsValid(intptr_t value);
-  static bool IsValid64(int64_t value);
+  static bool IsValid(intptr_t value) {
+    return (value >= kMinValue) && (value <= kMaxValue);
+  }
+
+  static bool IsValid64(int64_t value) {
+    return (value >= kMinValue) && (value <= kMaxValue);
+  }
 
  private:
+  friend class Api;  // For ValueFromRaw

[cshapiro, 2012/04/16 20:32:45]

Co-locate this with the other friend classes below?

+
   static intptr_t ValueFromRaw(uword raw_value) {
     intptr_t value = raw_value;
     ASSERT((value & kSmiTagMask) == kSmiTag);
     return (value >> kSmiTagShift);
   }
   static cpp_vtable handle_vtable_;
 
   OBJECT_IMPLEMENTATION(Smi, Integer);
   friend class Object;
   friend class Class;
@@ skipping 1232 matching lines @@
 }
 
 
 intptr_t Stackmap::SizeInBits() const {
   return (Smi::Value(raw_ptr()->bitmap_size_in_bytes_) * kBitsPerByte);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_