Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 10052006: Merge 131324 - Mac: OOP font loading should run on FILE thread. (Closed)

Created:
8 years, 8 months ago by bashi
Modified:
8 years, 8 months ago
Reviewers:
bashi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Merge 131324 - Mac: OOP font loading should run on FILE thread. FontLoader calls file_util::GetFileSize() and file_util::ReadFile(), which should be called from the file thread, but FontLoader runs on the io thread now. Make it run on the file thread. BUG=108645 TEST=none Review URL: http://codereview.chromium.org/9950141 TBR=bashi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -69 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 2 chunks +7 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +23 lines, -20 lines 0 comments Download
M content/common/mac/font_loader.h View 2 chunks +20 lines, -11 lines 0 comments Download
M content/common/mac/font_loader.mm View 6 chunks +23 lines, -24 lines 0 comments Download
M content/common/sandbox_mac_fontloading_unittest.mm View 3 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
bashi
8 years, 8 months ago (2012-04-11 02:30:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698