Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 10051030: Fix for local variable rename, when it is expression of invocation. (Closed)

Created:
8 years, 8 months ago by scheglov
Modified:
8 years, 8 months ago
Reviewers:
jwren, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for local variable rename, when it is expression of invocation. Corresponging test for RenameLinkedMode, mostly to show how tests like this look. R=jwren@google.com,danrubel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1018 lines, -161 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/NodeFinder.java View 1 chunk +0 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/general/StringUtilities.java View 2 chunks +299 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui.swtbot_test/META-INF/MANIFEST.MF View 2 chunks +4 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui.swtbot_test/src/com/google/dart/tools/ui/internal/refactoring/AbstractDartEditorTest.java View 1 chunk +81 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui.swtbot_test/src/com/google/dart/tools/ui/internal/refactoring/EventSender.java View 1 chunk +465 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui.swtbot_test/src/com/google/dart/tools/ui/internal/refactoring/RenameLinkedModeTest.java View 1 chunk +61 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui.swtbot_test/src/com/google/dart/tools/ui/internal/refactoring/TestAll.java View 1 chunk +25 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/META-INF/MANIFEST.MF View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/dom/LinkedNodeFinder.java View 4 chunks +7 lines, -14 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/ExecutionUtils.java View 1 chunk +14 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/META-INF/MANIFEST.MF View 1 chunk +1 line, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/AbstractDartTest.java View 3 chunks +28 lines, -30 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/ExecutionUtilsTest.java View 1 chunk +28 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RefactoringTest.java View 3 chunks +3 lines, -108 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 8 months ago (2012-04-13 03:25:49 UTC) #1
jwren
8 years, 8 months ago (2012-04-13 21:31:14 UTC) #2
On 2012/04/13 03:25:49, scheglov wrote:

LGTM

Powered by Google App Engine
This is Rietveld 408576698