chromeos: Stop leaking combobox models in VPNConfigView dialog.

chromeos: Stop leaking combobox models in VPNConfigView dialog.

This is needed, because views::Combobox does NOT own its model.

BUG=122092
TEST=play with this dialog, try the comboboxes, they should work as before, and
we shouldn't see any crashes.
R=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132188

[tfarina, 2012-04-11 22:48:27]

http://codereview.chromium.org/10050030/diff/1/chrome/browser/chromeos/option...
File chrome/browser/chromeos/options/vpn_config_view.h (right):

http://codereview.chromium.org/10050030/diff/1/chrome/browser/chromeos/option...
chrome/browser/chromeos/options/vpn_config_view.h:22: namespace internal {
I put this outside of chromeos namespace intentionally.
Otherwise, I get errors like:

/usr/local/gold/bin/ld: error:
obj/chrome/libbrowser.a(obj/chrome/browser/chromeos/options/browser.wifi_config_view.o):
multiple definition of
'chromeos::internal::ServerCACertComboboxModel::ServerCACertComboboxModel(chromeos::CertLibrary*)'

[stevenjb, 2012-04-12 17:46:28]

http://codereview.chromium.org/10050030/diff/1/chrome/browser/chromeos/option...
File chrome/browser/chromeos/options/vpn_config_view.h (right):

http://codereview.chromium.org/10050030/diff/1/chrome/browser/chromeos/option...
chrome/browser/chromeos/options/vpn_config_view.h:22: namespace internal {
On 2012/04/11 22:48:27, tfarina wrote:
> I put this outside of chromeos namespace intentionally.
> Otherwise, I get errors like:
> 
> /usr/local/gold/bin/ld: error:
>
obj/chrome/libbrowser.a(obj/chrome/browser/chromeos/options/browser.wifi_config_view.o):
> multiple definition of
>
'chromeos::internal::ServerCACertComboboxModel::ServerCACertComboboxModel(chromeos::CertLibrary*)'

We shouldn't use 'chromeos' as the differentiator between these and the classes
in wifi_config_view. We should rename this one VpnServerCACertComboboxModel.

[tfarina, 2012-04-12 19:05:28]

On 2012/04/12 17:46:28, stevenjb (chromium) wrote:
>
http://codereview.chromium.org/10050030/diff/1/chrome/browser/chromeos/option...
> File chrome/browser/chromeos/options/vpn_config_view.h (right):
> 
>
http://codereview.chromium.org/10050030/diff/1/chrome/browser/chromeos/option...
> chrome/browser/chromeos/options/vpn_config_view.h:22: namespace internal {
> On 2012/04/11 22:48:27, tfarina wrote:
> > I put this outside of chromeos namespace intentionally.
> > Otherwise, I get errors like:
> > 
> > /usr/local/gold/bin/ld: error:
> >
>
obj/chrome/libbrowser.a(obj/chrome/browser/chromeos/options/browser.wifi_config_view.o):
> > multiple definition of
> >
>
'chromeos::internal::ServerCACertComboboxModel::ServerCACertComboboxModel(chromeos::CertLibrary*)'
> 
> We shouldn't use 'chromeos' as the differentiator between these and the
classes
> in wifi_config_view. We should rename this one VpnServerCACertComboboxModel.

Done.

[stevenjb, 2012-04-12 22:13:45]

lgtm