Removes pinning code from TopSites as we no longer need it.

chrome/browser/history/top_sites_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 840 matching lines @@
 
   {
     TopSitesQuerier querier;
     querier.QueryTopSites(top_sites(), false);
 
     ASSERT_EQ(GetPrepopulatePages().size(), querier.urls().size());
     ASSERT_NO_FATAL_FAILURE(ContainsPrepopulatePages(querier, 0));
   }
 }
 
-TEST_F(TopSitesTest, PinnedURLsDeleted) {
-  GURL google1_url("http://google.com");
-  GURL google2_url("http://google.com/redirect");
-  GURL google3_url("http://www.google.com");
-  string16 google_title(ASCIIToUTF16("Google"));
-  GURL news_url("http://news.google.com");
-  string16 news_title(ASCIIToUTF16("Google News"));
-
-  AddPageToHistory(google1_url, google_title);
-  AddPageToHistory(news_url, news_title);
-
-  RefreshTopSitesAndRecreate();
-
-  {
-    TopSitesQuerier querier;
-    querier.QueryTopSites(top_sites(), false);
-
-    // Take into account prepopulated URLs.
-    ASSERT_EQ(GetPrepopulatePages().size() + 2, querier.urls().size());
-  }
-
-  top_sites()->AddPinnedURL(news_url, 3);
-  EXPECT_TRUE(top_sites()->IsURLPinned(news_url));
-
-  DeleteURL(news_url);
-  WaitForHistory();
-
-  {
-    TopSitesQuerier querier;
-    querier.QueryTopSites(top_sites(), false);
-
-    // Take into account prepopulated URLs.
-    ASSERT_EQ(GetPrepopulatePages().size() + 1, querier.urls().size());
-    EXPECT_FALSE(top_sites()->IsURLPinned(news_url));
-  }
-
-  history_service()->ExpireHistoryBetween(
-      std::set<GURL>(), base::Time(), base::Time(),
-      consumer(), base::Bind(&TopSitesTest::EmptyCallback,
-                             base::Unretained(this))),
-  WaitForHistory();
-
-  {
-    TopSitesQuerier querier;
-    querier.QueryTopSites(top_sites(), false);
-
-    // Take into account prepopulated URLs.
-    ASSERT_EQ(GetPrepopulatePages().size(), querier.urls().size());
-    EXPECT_FALSE(top_sites()->IsURLPinned(google1_url));
-    ASSERT_NO_FATAL_FAILURE(ContainsPrepopulatePages(querier, 0));
-  }
-}
-
 // Makes sure GetUpdateDelay is updated appropriately.
 TEST_F(TopSitesTest, GetUpdateDelay) {
   SetLastNumUrlsChanged(0);
   EXPECT_EQ(30, GetUpdateDelay().InSeconds());
 
   MostVisitedURLList url_list;
   url_list.resize(20);
   GURL tmp_url(GURL("http://x"));
   for (size_t i = 0; i < url_list.size(); ++i) {
     url_list[i].url = tmp_url;
@@ skipping 276 matching lines @@
   {
     TopSitesQuerier q;
     q.QueryTopSites(top_sites(), true);
     ASSERT_EQ(2u + GetPrepopulatePages().size(), q.urls().size());
     EXPECT_EQ("http://bbc.com/", q.urls()[0].url.spec());
     EXPECT_EQ("http://google.com/", q.urls()[1].url.spec());
     ASSERT_NO_FATAL_FAILURE(ContainsPrepopulatePages(q, 2));
   }
 }
 
-// Tests variations of pinning/unpinning urls.
-TEST_F(TopSitesTest, PinnedURLs) {
-  MostVisitedURLList pages;
-  MostVisitedURL url, url1;
-  url.url = GURL("http://bbc.com/");
-  url.redirects.push_back(url.url);
-  pages.push_back(url);
-  url1.url = GURL("http://google.com/");
-  url1.redirects.push_back(url1.url);
-  pages.push_back(url1);
-
-  SetTopSites(pages);
-
-  EXPECT_FALSE(top_sites()->IsURLPinned(GURL("http://bbc.com/")));
-
-  {
-    TopSitesQuerier q;
-    q.QueryTopSites(top_sites(), true);
-    ASSERT_EQ(2u + GetPrepopulatePages().size(), q.urls().size());
-    EXPECT_EQ("http://bbc.com/", q.urls()[0].url.spec());
-    EXPECT_EQ("http://google.com/", q.urls()[1].url.spec());
-    ASSERT_NO_FATAL_FAILURE(ContainsPrepopulatePages(q, 2));
-  }
-
-  top_sites()->AddPinnedURL(GURL("http://google.com/"), 3);
-  EXPECT_FALSE(top_sites()->IsURLPinned(GURL("http://bbc.com/")));
-  EXPECT_FALSE(top_sites()->IsURLPinned(GetPrepopulatePages()[0].url));
-
-  {
-    TopSitesQuerier q;
-    q.QueryTopSites(top_sites(), true);
-    ASSERT_EQ(4u, q.urls().size());
-    EXPECT_EQ("http://bbc.com/", q.urls()[0].url.spec());
-    ASSERT_NO_FATAL_FAILURE(ContainsPrepopulatePages(q, 1));
-    EXPECT_EQ("http://google.com/", q.urls()[3].url.spec());
-  }
-
-  top_sites()->RemovePinnedURL(GURL("http://google.com/"));
-  EXPECT_FALSE(top_sites()->IsURLPinned(GURL("http://google.com/")));
-  {
-    TopSitesQuerier q;
-    q.QueryTopSites(top_sites(), true);
-
-    ASSERT_EQ(2u + GetPrepopulatePages().size(), q.urls().size());
-    EXPECT_EQ("http://bbc.com/", q.urls()[0].url.spec());
-    EXPECT_EQ("http://google.com/", q.urls()[1].url.spec());
-    ASSERT_NO_FATAL_FAILURE(ContainsPrepopulatePages(q, 2));
-  }
-
-  GURL prepopulate_url = GetPrepopulatePages()[0].url;
-  top_sites()->AddPinnedURL(GURL("http://bbc.com"), 1);
-  top_sites()->AddPinnedURL(prepopulate_url, 0);
-  {
-    TopSitesQuerier q;
-    q.QueryTopSites(top_sites(), true);
-
-    ASSERT_EQ(3u + GetPrepopulatePages().size() - 1, q.urls().size());
-    EXPECT_EQ(prepopulate_url, q.urls()[0].url);
-    EXPECT_EQ("http://bbc.com/", q.urls()[1].url.spec());
-    EXPECT_EQ("http://google.com/", q.urls()[2].url.spec());
-    if (GetPrepopulatePages().size() > 1)
-      EXPECT_EQ(GetPrepopulatePages()[1].url, q.urls()[3].url);
-  }
-
-  // Recreate and make sure state remains the same.
-  RecreateTopSitesAndBlock();
-  {
-    TopSitesQuerier q;
-    q.QueryTopSites(top_sites(), true);
-
-    ASSERT_EQ(3u + GetPrepopulatePages().size() - 1, q.urls().size());
-    EXPECT_EQ(prepopulate_url, q.urls()[0].url);
-    EXPECT_EQ("http://bbc.com/", q.urls()[1].url.spec());
-    EXPECT_EQ("http://google.com/", q.urls()[2].url.spec());
-    if (GetPrepopulatePages().size() > 1)
-      EXPECT_EQ(GetPrepopulatePages()[1].url, q.urls()[3].url);
-  }
-}
-
-// Tests blacklisting and pinning.
-TEST_F(TopSitesTest, BlacklistingAndPinnedURLs) {
-  MostVisitedURLList prepopulate_urls = GetPrepopulatePages();
-  if (prepopulate_urls.size() < 2)
-    return;
-
-  top_sites()->AddPinnedURL(prepopulate_urls[0].url, 1);
-  top_sites()->AddBlacklistedURL(prepopulate_urls[1].url);
-
-  {
-    TopSitesQuerier q;
-    q.QueryTopSites(top_sites(), true);
-
-    ASSERT_LE(2u, q.urls().size());
-    EXPECT_EQ(GURL(), q.urls()[0].url);
-    EXPECT_EQ(prepopulate_urls[0].url, q.urls()[1].url);
-  }
-}
-
 // Makes sure prepopulated pages exist.
 TEST_F(TopSitesTest, AddPrepopulatedPages) {
   TopSitesQuerier q;
   q.QueryTopSites(top_sites(), true);
   EXPECT_EQ(GetPrepopulatePages().size(), q.urls().size());
   ASSERT_NO_FATAL_FAILURE(ContainsPrepopulatePages(q, 0));
 
   MostVisitedURLList pages = q.urls();
   EXPECT_FALSE(AddPrepopulatedPages(&pages));
 
@@ skipping 67 matching lines @@
   ui_test_utils::WindowedNotificationObserver observer(
       chrome::NOTIFICATION_TOP_SITES_LOADED,
       content::Source<Profile>(profile()));
   profile()->CreateTopSites();
   profile()->GetHistoryService(Profile::EXPLICIT_ACCESS)->UnloadBackend();
   profile()->BlockUntilHistoryProcessesPendingRequests();
   observer.Wait();
 }
 
 }  // namespace history