Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: include/v8-profiler.h

Issue 10049002: Introduce a way to grab heap stats. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: cosmetic changes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index e36659fb48da438082baa47090c66ab77ca05da5..b8312f4edc40d258fe0d63076a491fb81a183561 100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -418,6 +418,25 @@ class V8EXPORT HeapProfiler {
ActivityControl* control = NULL);
/**
+ * This method gives us an update of the heap state.
mnaganov (inactive) 2012/04/12 13:32:26 Comments look a bit weird. How about putting Start
+ * It appends a new time interval to an aggegated stats array,
+ * traverse the heap and: assign ids to new objects, remove ids of collected
+ * objects, count of alive objects for the each time interval and if the stats
+ * for a time interval were changed, report the new stats to the caller via
+ * OutputStream object.
+ */
+ static void PushHeapObjectsStats(OutputStream* stream);
mnaganov (inactive) 2012/04/12 13:32:26 nit: add a blank line before the comment
+ /**
+ * At GC phase objects can be moved and we want to track these movements.
+ * in the other case we will count moved objects as new.
+ */
+ static void StartHeapObjectsTracking();
mnaganov (inactive) 2012/04/12 13:32:26 nit: add a blank line before the comment
+ /**
+ * Stop objects movements tracking and clean the list of time intervals.
+ */
+ static void StopHeapObjectsTracking();
+
+ /**
* Deletes all snapshots taken. All previously returned pointers to
* snapshots and their contents become invalid after this call.
*/

Powered by Google App Engine
This is Rietveld 408576698