Introduce a way to grab heap stats.

src/profile-generator.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1388 matching lines @@
     entry_info.accessed = true;
     ASSERT(static_cast<uint32_t>(entries_->length()) >
            entries_map_.occupancy());
     return entry_info.id;
   } else {
     return 0;
   }
 }
 
 
+SnapshotObjectId HeapObjectsMap::FindOrAddEntry(Address addr) {

[mnaganov (inactive), 2012/04/11 14:35:40]

This functions seems to reuse code from FindEntry, FindObject and AddEntry. Can
you please try to avoid code duplication?

+  ASSERT(static_cast<uint32_t>(entries_->length()) > entries_map_.occupancy());
+  HashMap::Entry* entry = entries_map_.Lookup(addr, AddressHash(addr), true);
+  if (entry->value != NULL) {
+    int entry_index =
+        static_cast<int>(reinterpret_cast<intptr_t>(entry->value));
+    EntryInfo& entry_info = entries_->at(entry_index);
+    entry_info.accessed = true;
+    return entry_info.id;
+  }
+  entry->value = reinterpret_cast<void*>(entries_->length());
+  SnapshotObjectId id = next_id_;
+  next_id_ += kObjectIdStep;
+  entries_->Add(EntryInfo(id, addr));
+  ASSERT(static_cast<uint32_t>(entries_->length()) > entries_map_.occupancy());
+  return id;
+}
+
+
+void HeapObjectsMap::StartHeapObjectsTracking() {
+}
+
+
+void HeapObjectsMap::StopHeapObjectsTracking() {
+  fragment_infos_.Clear();
+}
+
+void HeapObjectsMap::UpdateHeapObjectsMap() {
+  HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask,
+                          "HeapSnapshotsCollection::UpdateHeapObjectsMap");
+  int entries = 0;
+  HeapIterator iterator(HeapIterator::kFilterUnreachable);
+  for (HeapObject* obj = iterator.next();
+       obj != NULL;
+       obj = iterator.next()) {
+    FindOrAddEntry(obj->address());
+    ++entries;
+  }
+  initial_fill_mode_ = false;
+  RemoveDeadEntries();
+}
+
+
+void HeapObjectsMap::PushHeapObjectsStats(OutputStream* stream) {
+  UpdateHeapObjectsMap();
+  fragment_infos_.Add(FragmentInfo(next_id_));
+  int collected_fragment_updates = 0;

[mnaganov (inactive), 2012/04/11 14:35:40]

This variable seems to be write-only.

+  int prefered_chunk_size = stream->GetChunkSize();
+  List<uint32_t> stats_buffer;
+  ASSERT(entries_->length());
+  EntryInfo* entry_info = &entries_->first();
+  EntryInfo* end_entry_info = &entries_->last() + 1;
+  uint32_t count = 0;
+  for (int fragment_index = 0;
+       fragment_index < fragment_infos_.length();
+       ++fragment_index) {
+    FragmentInfo& fragment_info = fragment_infos_[fragment_index];
+    SnapshotObjectId fragment_id = fragment_info.id;
+    while (entry_info < end_entry_info && entry_info->id < fragment_id) {
+      ++count;
+      ++entry_info;
+    }
+    if (fragment_info.count != count) {
+      stats_buffer.Add(fragment_index);
+      stats_buffer.Add(fragment_info.count = count);
+      ++collected_fragment_updates;
+      if (stats_buffer.length() >= prefered_chunk_size) {
+        stream->WriteUint32Chunk(&stats_buffer.first(),
+                                 stats_buffer.length());
+        stats_buffer.Clear();
+      }
+    }
+    count = 0;
+  }
+  ASSERT(entry_info == end_entry_info);
+  if (stats_buffer.length()) {
+    stream->WriteUint32Chunk(&stats_buffer.first(), stats_buffer.length());
+  }
+  stream->EndOfStream();
+}
+
+
 void HeapObjectsMap::RemoveDeadEntries() {
   ASSERT(entries_->length() > 0 &&
          entries_->at(0).id == 0 &&
          entries_->at(0).addr == NULL);
   int first_free_entry = 1;
   for (int i = 1; i < entries_->length(); ++i) {
     EntryInfo& entry_info = entries_->at(i);
     if (entry_info.accessed) {
       if (first_free_entry != i) {
         entries_->at(first_free_entry) = entry_info;
@@ skipping 2367 matching lines @@
 
 
 void HeapSnapshotJSONSerializer::SortHashMap(
     HashMap* map, List<HashMap::Entry*>* sorted_entries) {
   for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p))
     sorted_entries->Add(p);
   sorted_entries->Sort(SortUsingEntryValue);
 }
 
 } }  // namespace v8::internal