Convert OSX intent picker unit tests to PlatformTests.

Convert OSX intent picker unit tests to PlatformTests.

Will stop open windows from staying around while other unit tests run.

TBR=jhawkins@chromium.org
BUG=122152
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134676

[groby-ooo-7-16, 2012-04-10 21:22:24]

rsesek: Please review
jhawkins: OWNERS heads up for gypi change

[Robert Sesek, 2012-04-12 14:03:19]

Sorry for the delay. Was sheriff the past two days.

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm (right):

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:28:
MockIntentPickerDelegate::MockIntentPickerDelegate() {
You could just inline these.

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:48: {
nit: goes on line 47

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:97:
//CreateBubble(browser()->GetSelectedTabContentsWrapper());
Remove?

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm (right):

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm:8: #import
"chrome/browser/ui/cocoa/web_intent_sheet_controller.h"
In test .cc/mm files, the .h for the implementation under test gets pulled out
as the first include, like in the implementation .cc/mm file.

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm:14: class
WebIntentPickerSheetControllerTest : public PlatformTest {
Use CocoaTest (cocoa_test_helpers.h)

[groby-ooo-7-16, 2012-04-16 23:03:14]

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm (right):

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:28:
MockIntentPickerDelegate::MockIntentPickerDelegate() {
Done. Hoping clang doesn't object :)

On 2012/04/12 14:03:19, rsesek wrote:
> You could just inline these.

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:48: {
On 2012/04/12 14:03:19, rsesek wrote:
> nit: goes on line 47

Done.

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:97:
//CreateBubble(browser()->GetSelectedTabContentsWrapper());
On 2012/04/12 14:03:19, rsesek wrote:
> Remove?

Done.

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm (right):

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm:8: #import
"chrome/browser/ui/cocoa/web_intent_sheet_controller.h"
On 2012/04/12 14:03:19, rsesek wrote:
> In test .cc/mm files, the .h for the implementation under test gets pulled out
> as the first include, like in the implementation .cc/mm file.

Done.

http://codereview.chromium.org/10048005/diff/1/chrome/browser/ui/cocoa/web_in...
chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm:14: class
WebIntentPickerSheetControllerTest : public PlatformTest {
On 2012/04/12 14:03:19, rsesek wrote:
> Use CocoaTest (cocoa_test_helpers.h)

Done.

[Robert Sesek, 2012-04-17 23:15:39]

http://codereview.chromium.org/10048005/diff/4001/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm (right):

http://codereview.chromium.org/10048005/diff/4001/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:30: void
CreateBubble(TabContentsWrapper* wrapper);
nit: indented 1 too many

http://codereview.chromium.org/10048005/diff/4001/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm (right):

http://codereview.chromium.org/10048005/diff/4001/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm:19: virtual void
SetUp() {
CocoaTest::SetUp()

http://codereview.chromium.org/10048005/diff/4001/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm:83:
scoped_nsobject<WebIntentPickerSheetController> controller_;
This doesn't own itself?

[groby-ooo-7-16, 2012-04-25 23:19:16]

https://chromiumcodereview.appspot.com/10048005/diff/4001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm (right):

https://chromiumcodereview.appspot.com/10048005/diff/4001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:30: void
CreateBubble(TabContentsWrapper* wrapper);
On 2012/04/17 23:15:39, rsesek wrote:
> nit: indented 1 too many

Done.

https://chromiumcodereview.appspot.com/10048005/diff/4001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm (right):

https://chromiumcodereview.appspot.com/10048005/diff/4001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm:19: virtual void
SetUp() {
On 2012/04/17 23:15:39, rsesek wrote:
> CocoaTest::SetUp()

Done.

https://chromiumcodereview.appspot.com/10048005/diff/4001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm:83:
scoped_nsobject<WebIntentPickerSheetController> controller_;
On 2012/04/17 23:15:39, rsesek wrote:
> This doesn't own itself?

Usually, it does. But releasing requires properly running it as a sheet and
dismissing the sheet. This test doesn't do that, so we manually need to release.
scoped_nsobject actually does this too late for CocoaTest cleanup warnings now,
so added TearDown() and manual release.

[Robert Sesek, 2012-04-30 23:54:29]

LGTM

https://chromiumcodereview.appspot.com/10048005/diff/8001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm (right):

https://chromiumcodereview.appspot.com/10048005/diff/8001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:13: #include
"testing/gmock/include/gmock/gmock.h"
nit: already #included

[groby-ooo-7-16, 2012-05-01 02:57:31]

https://chromiumcodereview.appspot.com/10048005/diff/8001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm (right):

https://chromiumcodereview.appspot.com/10048005/diff/8001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm:13: #include
"testing/gmock/include/gmock/gmock.h"
On 2012/04/30 23:54:30, rsesek wrote:
> nit: already #included

Done.

[commit-bot: I haz the power, 2012-05-01 02:57:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10048005/13002

[commit-bot: I haz the power, 2012-05-01 04:25:52]

Change committed as 134676