Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Side by Side Diff: remoting/host/installer/chromoting.wxs

Issue 10048003: The Chromoting service should not start automatically unless it was configured from the webapp to d… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <?xml version="1.0"?> 1 <?xml version="1.0"?>
2 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> 2 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
3 3
4 <?define EventSourceName = "chromoting" ?> 4 <?define EventSourceName = "chromoting" ?>
5 <?define ServiceName = "chromoting" ?> 5 <?define ServiceName = "chromoting" ?>
6 6
7 <?ifdef OfficialBuild ?> 7 <?ifdef OfficialBuild ?>
8 <?define ChromotingHost = "Chrome Remote Desktop Host" ?> 8 <?define ChromotingHost = "Chrome Remote Desktop Host" ?>
9 <?define FirewallName = "Chrome Remote Desktop Host" ?> 9 <?define FirewallName = "Chrome Remote Desktop Host" ?>
10 <?define Manufacturer = "Google Inc." ?> 10 <?define Manufacturer = "Google Inc." ?>
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 Name="remoting_service.exe" 101 Name="remoting_service.exe"
102 Vital="yes"/> 102 Vital="yes"/>
103 103
104 <ServiceInstall Id="install_service" 104 <ServiceInstall Id="install_service"
105 Type="ownProcess" 105 Type="ownProcess"
106 Vital="yes" 106 Vital="yes"
107 Name="$(var.ServiceName)" 107 Name="$(var.ServiceName)"
108 DisplayName="@[#remoting_service.exe],-101" 108 DisplayName="@[#remoting_service.exe],-101"
109 Description="@[#remoting_service.exe],-102" 109 Description="@[#remoting_service.exe],-102"
110 Arguments="--host-binary=&quot;[#remoting_me2me_host.exe ]&quot; --auth-config=&quot;[config_files]host.json&quot; --host-config=&quot;[c onfig_files]host.json&quot;" 110 Arguments="--host-binary=&quot;[#remoting_me2me_host.exe ]&quot; --auth-config=&quot;[config_files]host.json&quot; --host-config=&quot;[c onfig_files]host.json&quot;"
111 Start="auto" 111 Start="demand"
112 Account="LocalSystem" 112 Account="LocalSystem"
113 ErrorControl="ignore" 113 ErrorControl="ignore"
114 Interactive="no" /> 114 Interactive="no" />
115 115
116 <ServiceControl Id="start_service" 116 <ServiceControl Id="start_service"
117 Stop="both" 117 Stop="both"
118 Remove="uninstall" 118 Remove="uninstall"
119 Name="$(var.ServiceName)" 119 Name="$(var.ServiceName)"
120 Wait="yes" /> 120 Wait="yes" />
121 121
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 Value="[binaries]"/> 280 Value="[binaries]"/>
281 </RegistryKey> 281 </RegistryKey>
282 </RegistryKey> 282 </RegistryKey>
283 </RegistryKey> 283 </RegistryKey>
284 </RegistryKey> 284 </RegistryKey>
285 </RegistryKey> 285 </RegistryKey>
286 286
287 </Component> 287 </Component>
288 </DirectoryRef> 288 </DirectoryRef>
289 289
290 <!-- The service is always installed in the stopped state with start type
291 set to 'manual'. This becomes a problem when upgrading an existing
292 installation that is configured to start the service automatically.
293
294 Here we check the startup type before making any changes, then restart
295 the service and change its startup type as needed once the installation
296 is finished. -->
297 <Property Id="CHROMOTING_SERVICE_START_TYPE">
298 <RegistrySearch Id="chromoting_service_start_type"
299 Root="HKLM"
300 Key="SYSTEM\CurrentControlSet\services\$(var.ServiceName)"
301 Name="Start"
302 Type="raw" />
303 </Property>
304
305 <CustomAction Id="query_auto_start_service"
306 Property="auto_start_service"
307 Value="[CHROMOTING_SERVICE_START_TYPE]" />
308
309 <CustomAction Id="set_auto_start_service" Script="jscript">
310 <![CDATA[
311 var controller = new ActiveXObject("$(var.ControllerProgid)");
312 controller.StartDaemon();
313 ]]>
314 </CustomAction>
315
290 <UIRef Id="WixUI_ErrorProgressText" /> 316 <UIRef Id="WixUI_ErrorProgressText" />
291 317
292 <Feature Id="chromoting_host" Level="1" Title="$(var.ChromotingHost)"> 318 <Feature Id="chromoting_host" Level="1" Title="$(var.ChromotingHost)">
293 <ComponentRef Id="omaha_registration"/> 319 <ComponentRef Id="omaha_registration"/>
294 <ComponentRef Id="remoting_host"/> 320 <ComponentRef Id="remoting_host"/>
295 <ComponentRef Id="sas.dll"/> 321 <ComponentRef Id="sas.dll"/>
296 <ComponentRef Id="service_controller"/> 322 <ComponentRef Id="service_controller"/>
297 </Feature> 323 </Feature>
298 324
325 <InstallExecuteSequence>
326 <Custom Action="query_auto_start_service" Before="InstallInitialize"/>
327 <Custom Action="set_auto_start_service" After="InstallFinalize">NOT INSTALLE D AND (auto_start_service = "#2")</Custom>
328 </InstallExecuteSequence>
329
299 </Product> 330 </Product>
300 </Wix> 331 </Wix>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698