Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: components/history/core/browser/history_backend.cc

Issue 1004373002: Add last_requested field to the favicon_bitmaps table of the favicons database. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge GetFaviconBitmapLastRequestedtime into GetFaviconBitmap. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/History/Favicons.v8.sql ('k') | components/history/core/browser/history_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_backend.cc
diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc
index 7285dae868772e5ab688322bde969db4edd87fb6..c257a7652bb8881fead51f17dad9ed6892134235 100644
--- a/components/history/core/browser/history_backend.cc
+++ b/components/history/core/browser/history_backend.cc
@@ -1529,7 +1529,8 @@ void HistoryBackend::GetLargestFaviconForURL(
favicon_base::FaviconRawBitmapResult bitmap_result;
bitmap_result.icon_url = icon_url;
bitmap_result.icon_type = icon_type;
- if (!thumbnail_db_->GetFaviconBitmap(largest_icon.bitmap_id, &last_updated,
+ if (!thumbnail_db_->GetFaviconBitmap(largest_icon.bitmap_id,
+ &last_updated, nullptr,
&bitmap_result.bitmap_data,
&bitmap_result.pixel_size)) {
return;
@@ -1966,8 +1967,8 @@ bool HistoryBackend::IsFaviconBitmapDataEqual(
return false;
scoped_refptr<base::RefCountedMemory> original_bitmap_data;
- thumbnail_db_->GetFaviconBitmap(bitmap_id, nullptr, &original_bitmap_data,
- nullptr);
+ thumbnail_db_->GetFaviconBitmap(bitmap_id, nullptr, nullptr,
+ &original_bitmap_data, nullptr);
return new_bitmap_data->Equals(original_bitmap_data);
}
@@ -2056,7 +2057,7 @@ bool HistoryBackend::GetFaviconBitmapResultsForBestMatch(
bitmap_result.icon_url = icon_url;
bitmap_result.icon_type = icon_type;
if (!thumbnail_db_->GetFaviconBitmap(best_bitmap_ids[i], &last_updated,
- &bitmap_result.bitmap_data,
+ nullptr, &bitmap_result.bitmap_data,
&bitmap_result.pixel_size)) {
return false;
}
« no previous file with comments | « chrome/test/data/History/Favicons.v8.sql ('k') | components/history/core/browser/history_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698