ash: Make the rows in IME and bluetooth tray-popups larger.

ash/system/bluetooth/tray_bluetooth.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/bluetooth/tray_bluetooth.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_item_more.h"
 #include "ash/system/tray/tray_views.h"
 #include "grit/ash_strings.h"
 #include "grit/ui_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/layout/box_layout.h"
 
 namespace {
-const int kDeviceListHeight = 190;
+const int kDeviceListHeight = 276;
 }
 
 namespace ash {
 namespace internal {
 
 namespace tray {
 
 class BluetoothDefaultView : public TrayItemMore {
  public:
   explicit BluetoothDefaultView(SystemTrayItem* owner)
@@ skipping 12 matching lines @@
     SetLabel(rb.GetLocalizedString(delegate->GetBluetoothEnabled() ?
         IDS_ASH_STATUS_TRAY_BLUETOOTH_CONNECTED :
         IDS_ASH_STATUS_TRAY_BLUETOOTH_DISABLED));
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BluetoothDefaultView);
 };
 
 class BluetoothDetailedView : public views::View,
-                              public ViewClickListener {
+                              public ViewClickListener,
+                              public views::ButtonListener {
  public:
   explicit BluetoothDetailedView(user::LoginStatus login)
       : login_(login),
         header_(NULL),
+        header_text_(NULL),
         add_device_(NULL),
         toggle_bluetooth_(NULL) {
     SetLayoutManager(new views::BoxLayout(
         views::BoxLayout::kVertical, 0, 0, 0));
     set_background(views::Background::CreateSolidBackground(kBackgroundColor));
 
     BluetoothDeviceList list;
     Shell::GetInstance()->tray_delegate()->GetAvailableBluetoothDevices(&list);
     Update(list);
   }
 
   virtual ~BluetoothDetailedView() {}
 
   void Update(const BluetoothDeviceList& list) {
     RemoveAllChildViews(true);
 
     header_ = NULL;
+    header_text_ = NULL;
     add_device_ = NULL;
     toggle_bluetooth_ = NULL;
 
     AppendHeaderEntry();
     AppendDeviceList(list);
     AppendSettingsEntries();
 
     Layout();
   }
 
  private:
   void AppendHeaderEntry() {
-    header_ = CreateDetailedHeaderEntry(IDS_ASH_STATUS_TRAY_BLUETOOTH, this);
+    header_ = new views::View;
+    header_->SetLayoutManager(new
+        views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0));
     AddChildView(header_);
+
+    header_text_ = CreateDetailedHeaderEntry(IDS_ASH_STATUS_TRAY_BLUETOOTH,
+                                             this);
+    header_->AddChildView(header_text_);
+
+    if (login_ == user::LOGGED_IN_LOCKED)
+      return;
+
+    // Do not allow toggling bluetooth in the lock screen.
+    ash::SystemTrayDelegate* delegate =
+        ash::Shell::GetInstance()->tray_delegate();
+    toggle_bluetooth_ = new TrayPopupHeaderButton(this,
+        IDR_AURA_UBER_TRAY_BLUETOOTH_ENABLED,
+        IDR_AURA_UBER_TRAY_BLUETOOTH_DISABLED);
+    toggle_bluetooth_->SetToggled(!delegate->GetBluetoothEnabled());
+    header_->AddChildView(toggle_bluetooth_);
   }
 
   void AppendDeviceList(const BluetoothDeviceList& list) {
     views::View* devices = new views::View;
     devices->SetLayoutManager(new views::BoxLayout(
         views::BoxLayout::kVertical, 0, 0, 1));
     device_map_.clear();
 
     for (size_t i = 0; i < list.size(); i++) {
       HoverHighlightView* container = new HoverHighlightView(this);
+      container->set_fixed_height(kTrayPopupItemHeight);
       container->AddLabel(list[i].display_name,
           list[i].connected ? gfx::Font::BOLD : gfx::Font::NORMAL);
       devices->AddChildView(container);
       device_map_[container] = list[i].address;
     }
 
     FixedSizedScrollView* scroller = new FixedSizedScrollView;
     scroller->set_border(views::Border::CreateSolidSidedBorder(1, 0, 1, 0,
         SkColorSetARGB(25, 0, 0, 0)));
     scroller->set_fixed_size(
         gfx::Size(devices->GetPreferredSize().width() +
                   scroller->GetScrollBarWidth(),
                   kDeviceListHeight));
     scroller->SetContentsView(devices);
     AddChildView(scroller);
   }
 
   // Add settings entries.
   void AppendSettingsEntries() {
-    // If screen is locked, hide all settings entries as user should not be able
-    // to modify state.
-    if (login_ == user::LOGGED_IN_LOCKED)
+    // Add bluetooth device requires a browser window, hide it for non logged in
+    // user.
+    if (login_ == user::LOGGED_IN_NONE ||
+        login_ == user::LOGGED_IN_LOCKED)
       return;
 
     ash::SystemTrayDelegate* delegate =
         ash::Shell::GetInstance()->tray_delegate();
+    ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
     HoverHighlightView* container = new HoverHighlightView(this);
-    ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+    container->set_fixed_height(kTrayPopupItemHeight);
     container->AddLabel(rb.GetLocalizedString(
-        delegate->GetBluetoothEnabled() ?
-            IDS_ASH_STATUS_TRAY_DISABLE_BLUETOOTH :
-            IDS_ASH_STATUS_TRAY_ENABLE_BLUETOOTH), gfx::Font::NORMAL);
+        IDS_ASH_STATUS_TRAY_BLUETOOTH_ADD_DEVICE), gfx::Font::NORMAL);
+    container->SetEnabled(delegate->GetBluetoothEnabled());
     AddChildView(container);
-    toggle_bluetooth_ = container;
+    add_device_ = container;
+  }
 
-    // Add bluetooth device requires a browser window, hide it for non logged in
-    // user.
-    if (login_ != user::LOGGED_IN_NONE) {
-      container = new HoverHighlightView(this);
-      container->AddLabel(rb.GetLocalizedString(
-            IDS_ASH_STATUS_TRAY_BLUETOOTH_ADD_DEVICE), gfx::Font::NORMAL);
-      AddChildView(container);
-      add_device_ = container;
+  // Overridden from views::View.
+  virtual void Layout() OVERRIDE {
+    views::View::Layout();
+    if (toggle_bluetooth_) {
+      // Right-align the toggle-bluetooth button.
+      gfx::Rect header_bounds = header_->bounds();
+      gfx::Size button_size = toggle_bluetooth_->size();
+
+      toggle_bluetooth_->SetBounds(header_->width() - button_size.width(), 0,
+          button_size.width(), header_->height());
+      header_text_->SetBounds(0, 0, header_->width() - button_size.width(),
+          header_->height());
     }
   }
 
   // Overridden from ViewClickListener.
   virtual void ClickedOn(views::View* sender) OVERRIDE {
     ash::SystemTrayDelegate* delegate =
         ash::Shell::GetInstance()->tray_delegate();
-    if (sender == header_) {
+    if (sender == header_text_) {
       Shell::GetInstance()->tray()->ShowDefaultView();
-    } else if (sender == toggle_bluetooth_) {
-      delegate->ToggleBluetooth();
     } else if (sender == add_device_) {
       delegate->AddBluetoothDevice();
     } else {
       std::map<views::View*, std::string>::iterator find;
       find = device_map_.find(sender);
       if (find != device_map_.end()) {
         std::string device_id = find->second;
         delegate->ToggleBluetoothConnection(device_id);
       }
     }
   }
 
+  // Overridden from ButtonListener.
+  virtual void ButtonPressed(views::Button* sender,
+                             const views::Event& event) OVERRIDE {
+    ash::SystemTrayDelegate* delegate =
+        ash::Shell::GetInstance()->tray_delegate();
+    if (sender == toggle_bluetooth_)
+      delegate->ToggleBluetooth();
+    else
+      NOTREACHED();
+  }
+
   user::LoginStatus login_;
 
   std::map<views::View*, std::string> device_map_;
   views::View* header_;
+  views::View* header_text_;
   views::View* add_device_;
-  views::View* toggle_bluetooth_;
+  TrayPopupHeaderButton* toggle_bluetooth_;
   views::View* settings_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothDetailedView);
 };
 
 }  // namespace tray
 
 TrayBluetooth::TrayBluetooth() {
 }
 
@@ skipping 33 matching lines @@
   BluetoothDeviceList list;
   Shell::GetInstance()->tray_delegate()->GetAvailableBluetoothDevices(&list);
   if (default_.get())
     default_->UpdateLabel();
   if (detailed_.get())
     detailed_->Update(list);
 }
 
 }  // namespace internal
 }  // namespace ash