Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 10041017: Show gpu process stats in about:tcmalloc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address nits, call OnStatsForChildProcess directly from IO thread instead of posting to UI Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/about_ui.cc
diff --git a/chrome/browser/ui/webui/about_ui.cc b/chrome/browser/ui/webui/about_ui.cc
index eb82960a3bced8080b722fd87d5e59c4e2dc3179..908d818db347777eee57c18a2b8150a91af96ed7 100644
--- a/chrome/browser/ui/webui/about_ui.cc
+++ b/chrome/browser/ui/webui/about_ui.cc
@@ -92,10 +92,6 @@
#include "base/string_split.h"
#endif
-#if defined(USE_TCMALLOC)
-#include "third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h"
-#endif
-
using base::Time;
using base::TimeDelta;
using content::BrowserThread;
@@ -788,51 +784,6 @@ class AboutDnsHandler : public base::RefCountedThreadSafe<AboutDnsHandler> {
DISALLOW_COPY_AND_ASSIGN(AboutDnsHandler);
};
-#if defined(USE_TCMALLOC)
-std::string AboutTcmalloc() {
- std::string data;
- AboutTcmallocOutputsType* outputs =
- AboutTcmallocOutputs::GetInstance()->outputs();
-
- // Display any stats for which we sent off requests the last time.
- AppendHeader(&data, 0, "About tcmalloc");
- AppendBody(&data);
- data.append("<p>Stats as of last page load;");
- data.append("reload to get stats as of this page load.</p>\n");
- data.append("<table width=\"100%\">\n");
- for (AboutTcmallocOutputsType::const_iterator oit = outputs->begin();
- oit != outputs->end();
- oit++) {
- data.append("<tr><td bgcolor=\"yellow\">");
- data.append(oit->first);
- data.append("</td></tr>\n");
- data.append("<tr><td><pre>\n");
- data.append(oit->second);
- data.append("</pre></td></tr>\n");
- }
- data.append("</table>\n");
- AppendFooter(&data);
-
- // Reset our collector singleton.
- outputs->clear();
-
- // Populate the collector with stats from the local browser process
- // and send off requests to all the renderer processes.
- char buffer[1024 * 32];
- MallocExtension::instance()->GetStats(buffer, sizeof(buffer));
- std::string browser("Browser");
- AboutTcmallocOutputs::GetInstance()->SetOutput(browser, buffer);
- content::RenderProcessHost::iterator
- it(content::RenderProcessHost::AllHostsIterator());
- while (!it.IsAtEnd()) {
- it.GetCurrentValue()->Send(new ChromeViewMsg_GetRendererTcmalloc);
- it.Advance();
- }
-
- return data;
-}
-#endif
-
std::string AboutHistograms(const std::string& query) {
TimeDelta wait_time = TimeDelta::FromMilliseconds(10000);
@@ -1462,10 +1413,6 @@ void AboutUIHTMLSource::StartDataRequest(const std::string& path,
#endif
} else if (host == chrome::kChromeUIStatsHost) {
response = AboutStats(path);
-#if defined(USE_TCMALLOC)
- } else if (host == chrome::kChromeUITCMallocHost) {
- response = AboutTcmalloc();
-#endif
} else if (host == chrome::kChromeUITermsHost) {
#if defined(OS_CHROMEOS)
ChromeOSTermsHandler::Start(this, path, request_id);

Powered by Google App Engine
This is Rietveld 408576698