Show gpu process stats in about:tcmalloc

chrome/browser/ui/webui/about_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/about_ui.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 28 matching lines @@
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/net/gaia/google_service_auth_error.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
+#include "content/public/browser/browser_child_process_host_iterator.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/child_process_data.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/process_type.h"
+#include "content/common/child_process_messages.h"
 #include "crypto/nss_util.h"
 #include "googleurl/src/gurl.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "net/base/escape.h"
 #include "net/base/net_util.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 714 matching lines @@
   // Where the results are fed to.
   scoped_refptr<AboutUIHTMLSource> source_;
 
   // ID identifying the request.
   int request_id_;
 
   DISALLOW_COPY_AND_ASSIGN(AboutDnsHandler);
 };
 
 #if defined(USE_TCMALLOC)
+void RequestTcmallocStatsFromChildProcesses() {
+  for (content::BrowserChildProcessHostIterator iter; !iter.Done(); ++iter) {
+    iter.Send(new ChildProcessMsg_GetTcmallocStats);
+  }
+}
+
 std::string AboutTcmalloc() {
   std::string data;
   AboutTcmallocOutputsType* outputs =
       AboutTcmallocOutputs::GetInstance()->outputs();
 
   // Display any stats for which we sent off requests the last time.
   AppendHeader(&data, 0, "About tcmalloc");
   AppendBody(&data);
   data.append("<p>Stats as of last page load;");
   data.append("reload to get stats as of this page load.</p>\n");
@@ skipping 13 matching lines @@
 
   // Reset our collector singleton.
   outputs->clear();
 
   // Populate the collector with stats from the local browser process
   // and send off requests to all the renderer processes.
   char buffer[1024 * 32];
   MallocExtension::instance()->GetStats(buffer, sizeof(buffer));
   std::string browser("Browser");
   AboutTcmallocOutputs::GetInstance()->SetOutput(browser, buffer);
+
+  // FIXME: Why do I have to iterate over both this and

[jam, 2012/04/18 23:06:41]

1) chrome code uses TODOs not FIXME :)
2) there are no plans to fix this, since too much of the UI code assumes that
RenderProcessHost lives on the UI thread. even if we moved it to the IO thread,
we'd still need another object to represent it on the UI thread..

so no need for this comment

+  // BrowserChildProcessHostIterator?
   content::RenderProcessHost::iterator
       it(content::RenderProcessHost::AllHostsIterator());
   while (!it.IsAtEnd()) {
-    it.GetCurrentValue()->Send(new ChromeViewMsg_GetRendererTcmalloc);
+    it.GetCurrentValue()->Send(new ChildProcessMsg_GetTcmallocStats);
     it.Advance();
   }
 
+  BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(

[jam, 2012/04/18 23:06:41]

nit: i think this is non standard tabbing per the style guide

i.e. the start of each line of parameters have to line up, so i'd do

BrowserThread::PostTask(
    BrowserThread::IO, FROM_HERE,
    base::Bind(&RequestTcmallocStatsFromChildProcesses));

+      &RequestTcmallocStatsFromChildProcesses));
   return data;
 }
 #endif
 
 std::string AboutHistograms(const std::string& query) {
   TimeDelta wait_time = TimeDelta::FromMilliseconds(10000);
 
 #ifndef NDEBUG
   base::StatisticsRecorder::CollectHistogramStats("Browser");
 #endif
@@ skipping 665 matching lines @@
 }
 
 AboutUI::AboutUI(content::WebUI* web_ui, const std::string& name)
     : WebUIController(web_ui) {
   Profile* profile = Profile::FromWebUI(web_ui);
   ChromeURLDataManager::DataSource* source =
       new AboutUIHTMLSource(name, profile);
   if (source)
     profile->GetChromeURLDataManager()->AddDataSource(source);
 }