Issue 10041005: Suppress DrMemory leak reports from the DhcpProxyScriptFetcherWin test suite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10041005: Suppress DrMemory leak reports from the DhcpProxyScriptFetcherWin test suite. (Closed)

Created:
8 years, 8 months ago by Reid Kleckner

Modified:
8 years, 8 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Suppress DrMemory leak reports from the DhcpProxyScriptFetcherWin test suite. This suite relies on the refcounting that used to happen for the URLRequestContext. BUG=123867 TBR=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132618

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tools/valgrind/drmemory/suppressions_full.txt	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

8 years, 8 months ago (2012-04-17 19:26:20 UTC) #2

LGTM

On Tue, Apr 17, 2012 at 12:23 PM, <rnk@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Suppress DrMemory leak reports from the DhcpProxyScriptFetcherWin test
> suite.
>
> This suite relies on the refcounting that used to happen for the
> URLRequestContext.
>
> BUG=123867
> TBR=willchan@chromium.org
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10041005/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M tools/valgrind/drmemory/**suppressions_full.txt
>
>
> Index: tools/valgrind/drmemory/**suppressions_full.txt
> diff --git a/tools/valgrind/drmemory/**suppressions_full.txt
> b/tools/valgrind/drmemory/**suppressions_full.txt
> index a29a60d5cd4613950a050e881fd319**df445709d4..**
> b42ce17eed89e207bc0c5c04846d4f**8e7d7d4d86 100644
> --- a/tools/valgrind/drmemory/**suppressions_full.txt
> +++ b/tools/valgrind/drmemory/**suppressions_full.txt
> @@ -1300,3 +1300,9 @@ ole32.dll!CoTaskMemAlloc
>  urlmon.dll!...
>  urlmon.dll!CreateUri
>  IEFRAME.dll!*
> +
> +# Win-only test leak.
> +LEAK
> +name=http://crbug.com/123867
> +...
> +*!*DhcpProxyScriptFetcherWin_***_Test::*
>
>
>

Expand Messages | Collapse Messages