Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: base/sys_info.h

Issue 10038034: Implemented a "Last Updated" field for the about page of Chrome OS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Moved #include's inside #if defined(OS_CHROMEOS) Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/sys_info_chromeos.cc » ('j') | chrome/browser/ui/webui/help/help_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info.h
diff --git a/base/sys_info.h b/base/sys_info.h
index f3677d6009f0e67147642c54a470fb3c97a3bde2..8669026d92e7548bf49a4449f1454104c981f681 100644
--- a/base/sys_info.h
+++ b/base/sys_info.h
@@ -8,6 +8,7 @@
#include "base/base_export.h"
#include "base/basictypes.h"
+#include "base/time.h"
#include <string>
@@ -74,6 +75,13 @@ class BASE_EXPORT SysInfo {
int32* major_version,
int32* minor_version,
int32* bugfix_version);
+
+ // Retrieves the approximate time that Chrome OS was last updated. Each time
+ // a new build is created, /etc/lsb-release is modified with the new version
+ // numbers of the release. We return the time at which that file was last
James Hawkins 2012/04/13 03:36:17 nit: Don't use pronouns, e.g. 'we', in comments; p
Kyle Horimoto 2012/04/13 18:12:38 Done.
+ // modified, which is a close approximation to the time the last Chrome OS
+ // update occurred.
+ static bool GetTimeLastUpdated(base::Time* time);
James Hawkins 2012/04/13 03:36:17 nit: Document |time|.
Kyle Horimoto 2012/04/13 18:12:38 Done.
#endif
James Hawkins 2012/04/13 03:36:17 #endif // defined(OS_CHROMEOS)
Kyle Horimoto 2012/04/13 18:12:38 Done.
};
« no previous file with comments | « no previous file | base/sys_info_chromeos.cc » ('j') | chrome/browser/ui/webui/help/help_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698