Implemented a "Last Updated" field for the about page of Chrome OS.

base/sys_info.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_SYS_INFO_H_
 #define BASE_SYS_INFO_H_
 #pragma once
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
+#include "base/time.h"
 
 #include <string>
 
 class FilePath;
 
 namespace base {
 
 class BASE_EXPORT SysInfo {

[James Hawkins, 2012/04/13 03:36:17]

Boo, this should really be a namespace :(

[Kyle Horimoto, 2012/04/13 18:12:38]

I'll leave it as a class for this CL and redo it as a namespace in another CL
because it'll be a widespread change.

  public:
   // Return the number of logical processors/cores on the current machine.
   static int NumberOfProcessors();
 
   // Return the number of bytes of physical memory on the current machine.
   static int64 AmountOfPhysicalMemory();
 
   // Return the number of megabytes of physical memory on the current machine.
   static int AmountOfPhysicalMemoryMB() {
     return static_cast<int>(AmountOfPhysicalMemory() / 1024 / 1024);
@@ skipping 38 matching lines @@
   // Returns the name of the version entry we wish to look up in the
   // Linux Standard Base release information file.
   static std::string GetLinuxStandardBaseVersionKey();
 
   // Parses /etc/lsb-release to get version information for Google Chrome OS.
   // Declared here so it can be exposed for unit testing.
   static void ParseLsbRelease(const std::string& lsb_release,
                               int32* major_version,
                               int32* minor_version,
                               int32* bugfix_version);
+
+  // Retrieves the approximate time that Chrome OS was last updated. Each time
+  // a new build is created, /etc/lsb-release is modified with the new version
+  // numbers of the release. We return the time at which that file was last

[James Hawkins, 2012/04/13 03:36:17]

nit: Don't use pronouns, e.g. 'we', in comments; pronouns are ambiguous.

[Kyle Horimoto, 2012/04/13 18:12:38]

Done.

+  // modified, which is a close approximation to the time the last Chrome OS
+  // update occurred.
+  static bool GetTimeLastUpdated(base::Time* time);

[James Hawkins, 2012/04/13 03:36:17]

nit: Document |time|.

[Kyle Horimoto, 2012/04/13 18:12:38]

Done.

 #endif

[James Hawkins, 2012/04/13 03:36:17]

#endif  // defined(OS_CHROMEOS)

[Kyle Horimoto, 2012/04/13 18:12:38]

Done.

 };
 
 }  // namespace base
 
 #endif  // BASE_SYS_INFO_H_