chrome/browser/resources/help/help.html - Issue 10038034: Implemented a "Last Updated" field for the about page of Chrome OS.

Side by Side Diff: chrome/browser/resources/help/help.html

Issue 10038034: Implemented a "Last Updated" field for the about page of Chrome OS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Added if statement to skip over string operations if string is already allocated Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection;">	2 <html i18n-values="dir:textdirection;">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title i18n-content="helpTitle"></title>	5 <title i18n-content="helpTitle"></title>

6 <link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css">	6 <link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css">

7 <link rel="stylesheet" href="../uber/uber_shared.css">	7 <link rel="stylesheet" href="../uber/uber_shared.css">

8 <link rel="stylesheet" href="help.css">	8 <link rel="stylesheet" href="help.css">

9 <script src="chrome://resources/js/cr.js"></script>	9 <script src="chrome://resources/js/cr.js"></script>

10 <script src="chrome://resources/js/local_strings.js"></script>	10 <script src="chrome://resources/js/local_strings.js"></script>

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 <div i18n-content="jsEngineVersion"></div>	55 <div i18n-content="jsEngineVersion"></div>

56 </section>	56 </section>

57 <section>	57 <section>

58 <h3 i18n-content="userAgent"></h3>	58 <h3 i18n-content="userAgent"></h3>

59 <div i18n-content="userAgentInfo" dir="ltr"></div>	59 <div i18n-content="userAgentInfo" dir="ltr"></div>

60 </section>	60 </section>

61 <section>	61 <section>

62 <h3 i18n-content="commandLine"></h3>	62 <h3 i18n-content="commandLine"></h3>

63 <div i18n-content="commandLineInfo" dir="ltr"></div>	63 <div i18n-content="commandLineInfo" dir="ltr"></div>

64 </section>	64 </section>

	65 <section id="last-updated-container" hidden>
	Evan Stade 2012/04/19 22:26:57 perhaps visibility: hidden would be better than hi perhaps visibility: hidden would be better than hidden attribute (i.e. display: none) for chromeos, because that way there won't be a flash/jiggle on load where this div is unhidden, and everything below it has to move down. Other platforms should I guess <if> guard this out. Kyle Horimoto 2012/04/23 20:37:03 Changed to "visibility: hidden". The whole "More I Show quoted text On 2012/04/19 22:26:57, Evan Stade wrote: > perhaps visibility: hidden would be better than hidden attribute (i.e. display: > none) for chromeos, because that way there won't be a flash/jiggle on load where > this div is unhidden, and everything below it has to move down. Other platforms > should I guess <if> guard this out. Changed to "visibility: hidden". The whole "More Info" area is <if> guarded out for other platforms, so putting extra ones around this <section> is unnecessary. Evan Stade 2012/04/24 18:21:52 ah i see Show quoted text On 2012/04/23 20:37:03, Kyle Horimoto wrote: > On 2012/04/19 22:26:57, Evan Stade wrote: > > perhaps visibility: hidden would be better than hidden attribute (i.e. > display: > > none) for chromeos, because that way there won't be a flash/jiggle on load > where > > this div is unhidden, and everything below it has to move down. Other > platforms > > should I guess <if> guard this out. > > Changed to "visibility: hidden". The whole "More Info" area is <if> guarded out > for other platforms, so putting extra ones around this <section> is unnecessary. ah i see
	66 <h3 i18n-content="lastUpdated"></h3>

	67 <div id="last-updated"></div>

	68 </section>

65 </div>	69 </div>

66 <button id="more-info-expander" class="link-button"	70 <button id="more-info-expander" class="link-button"

67 i18n-content="showMoreInfo">	71 i18n-content="showMoreInfo">

68 </button>	72 </button>

69 </if>	73 </if>

70 <if expr="pp_ifdef('chromeos') or (pp_ifdef('_google_chrome') and (is_win or is_ macosx))">	74 <if expr="pp_ifdef('chromeos') or (pp_ifdef('_google_chrome') and (is_win or is_ macosx))">

71 <div id="update-status-container">	75 <div id="update-status-container">

72 <div id="update-status-icon" class="up-to-date"></div>	76 <div id="update-status-icon" class="up-to-date"></div>

73 <span id="update-status" i18n-content="updateCheckStarted"></span>	77 <span id="update-status" i18n-content="updateCheckStarted"></span>

74 </div>	78 </div>

(...skipping 14 matching lines...) Expand all Loading...
89 <if expr="pp_ifdef('_google_chrome')">	93 <if expr="pp_ifdef('_google_chrome')">

90 <div id="product-tos"></div>	94 <div id="product-tos"></div>

91 </if>	95 </if>

92 </div>	96 </div>

93 </div>	97 </div>

94 </body>	98 </body>

95 <script src="chrome://help-frame/strings.js"></script>	99 <script src="chrome://help-frame/strings.js"></script>

96 <script src="chrome://resources/js/i18n_template.js"></script>	100 <script src="chrome://resources/js/i18n_template.js"></script>

97 <script src="chrome://resources/js/i18n_process.js"></script>	101 <script src="chrome://resources/js/i18n_process.js"></script>

98 </html>	102 </html>

OLD	NEW

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/help/help.js » ('j') | chrome/browser/ui/webui/help/help_handler.cc » ('J')