Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 10038020: Disable Set wallpaper option in context menu for guest user instead of remove it (Closed)

Created:
8 years, 8 months ago by bshe
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Disable Set wallpaper option in context menu for guest user instead of remove it and change "Set Wallpaper..." string to "Set wallpaper..." BUG=120763, 122728 TEST=Loggin as guest, close all browser windows, right click on desktop background, verify the "Set wallpaper..." option in the context menu is disabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132187

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Nit #

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M ash/ash_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_context_menu.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bshe
Hi Scott. Could you please take a look at this small CL? It seems for ...
8 years, 8 months ago (2012-04-12 15:45:30 UTC) #1
sky
LGTM https://chromiumcodereview.appspot.com/10038020/diff/1001/ash/shell_context_menu.cc File ash/shell_context_menu.cc (right): https://chromiumcodereview.appspot.com/10038020/diff/1001/ash/shell_context_menu.cc#newcode44 ash/shell_context_menu.cc:44: if (Shell::GetInstance()->user_wallpaper_delegate()-> nit: no need for the conditional: ...
8 years, 8 months ago (2012-04-12 16:08:35 UTC) #2
bshe
Thanks! commit it now. https://chromiumcodereview.appspot.com/10038020/diff/1001/ash/shell_context_menu.cc File ash/shell_context_menu.cc (right): https://chromiumcodereview.appspot.com/10038020/diff/1001/ash/shell_context_menu.cc#newcode44 ash/shell_context_menu.cc:44: if (Shell::GetInstance()->user_wallpaper_delegate()-> On 2012/04/12 16:08:35, ...
8 years, 8 months ago (2012-04-12 17:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/10038020/8
8 years, 8 months ago (2012-04-12 17:50:05 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-12 20:56:36 UTC) #5
Try job failure for 10038020-8 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698