src/x64/stub-cache-x64.cc - Issue 10038010: Fix regular and ElementsKind transitions interfering with each other

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/stub-cache-x64.cc

Issue 10038010: Fix regular and ElementsKind transitions interfering with each other (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/stub-cache-x64.cc

diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc

index 1103ec5caec245a701478e30aeead523cfb1c255..af810c1a6c2235374930afe0b82c9d0447258436 100644

--- a/src/x64/stub-cache-x64.cc

+++ b/src/x64/stub-cache-x64.cc

@@ -730,8 +730,10 @@ void StubCompiler::GenerateStoreField(MacroAssembler* masm,

Label* miss_label) {

// Check that the map of the object hasn't changed.

+ CompareMapMode mode = transition.is_null() ? ALLOW_ELEMENT_TRANSITION_MAPS

+ : REQUIRE_EXACT_MAP;

__ CheckMap(receiver_reg, Handle<Map>(object->map()),

- miss_label, DO_SMI_CHECK, ALLOW_ELEMENT_TRANSITION_MAPS);

+ miss_label, DO_SMI_CHECK, mode);

// Perform global security token check if needed.

if (object->IsJSGlobalProxy()) {

« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | test/mjsunit/regress/regress-crbug-122271.js » ('j') | no next file with comments »