Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 10038010: Fix regular and ElementsKind transitions interfering with each other (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 Handle<JSObject> object, 422 Handle<JSObject> object,
423 int index, 423 int index,
424 Handle<Map> transition, 424 Handle<Map> transition,
425 Register receiver_reg, 425 Register receiver_reg,
426 Register name_reg, 426 Register name_reg,
427 Register scratch, 427 Register scratch,
428 Label* miss_label) { 428 Label* miss_label) {
429 // a0 : value. 429 // a0 : value.
430 Label exit; 430 Label exit;
431 // Check that the map of the object hasn't changed. 431 // Check that the map of the object hasn't changed.
432 CompareMapMode mode = transition.is_null() ? ALLOW_ELEMENT_TRANSITION_MAPS
433 : REQUIRE_EXACT_MAP;
432 __ CheckMap(receiver_reg, scratch, Handle<Map>(object->map()), miss_label, 434 __ CheckMap(receiver_reg, scratch, Handle<Map>(object->map()), miss_label,
433 DO_SMI_CHECK, ALLOW_ELEMENT_TRANSITION_MAPS); 435 DO_SMI_CHECK, mode);
434 436
435 // Perform global security token check if needed. 437 // Perform global security token check if needed.
436 if (object->IsJSGlobalProxy()) { 438 if (object->IsJSGlobalProxy()) {
437 __ CheckAccessGlobalProxy(receiver_reg, scratch, miss_label); 439 __ CheckAccessGlobalProxy(receiver_reg, scratch, miss_label);
438 } 440 }
439 441
440 // Stub never generated for non-global objects that require access 442 // Stub never generated for non-global objects that require access
441 // checks. 443 // checks.
442 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded()); 444 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
443 445
(...skipping 4066 matching lines...) Expand 10 before | Expand all | Expand 10 after
4510 __ Jump(ic_slow, RelocInfo::CODE_TARGET); 4512 __ Jump(ic_slow, RelocInfo::CODE_TARGET);
4511 } 4513 }
4512 } 4514 }
4513 4515
4514 4516
4515 #undef __ 4517 #undef __
4516 4518
4517 } } // namespace v8::internal 4519 } } // namespace v8::internal
4518 4520
4519 #endif // V8_TARGET_ARCH_MIPS 4521 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698