Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 10038009: Revert 131949 (multiple memory leaks) - Adding JSEP PeerConnection glue. (Closed)

Created:
8 years, 8 months ago by eugenis
Modified:
8 years, 8 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Revert 131949 (multiple memory leaks) - Adding JSEP PeerConnection glue. This adds glue for JSEP PeerConnection. PeerConnectionHandler is split in two classes and a base class. The class name is kept for the old ROAP PeerConnection to be aligned with WebKit naming. ROAP is planned to be removed pretty soon, then the classes can be refactored. See also main WebKit bug https://bugs.webkit.org/show_bug.cgi?id=80589 (In particular https://bugs.webkit.org/show_bug.cgi?id=82450) TEST=content_unittests and manual webrtc test. Review URL: http://codereview.chromium.org/9699069 TBR=grunell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -1391 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_center.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_center.cc View 2 chunks +0 lines, -39 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 6 chunks +8 lines, -20 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 5 chunks +33 lines, -55 lines 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 2 chunks +3 lines, -65 lines 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.cc View 4 chunks +2 lines, -74 lines 0 comments Download
M content/renderer/media/mock_media_stream_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.h View 2 chunks +1 line, -24 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.cc View 4 chunks +21 lines, -31 lines 0 comments Download
D content/renderer/media/mock_web_peer_connection_00_handler_client.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/renderer/media/mock_web_peer_connection_00_handler_client.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M content/renderer/media/peer_connection_handler.h View 3 chunks +43 lines, -6 lines 0 comments Download
M content/renderer/media/peer_connection_handler.cc View 6 chunks +107 lines, -13 lines 0 comments Download
D content/renderer/media/peer_connection_handler_base.h View 1 chunk +0 lines, -71 lines 0 comments Download
D content/renderer/media/peer_connection_handler_base.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D content/renderer/media/peer_connection_handler_jsep.h View 1 chunk +0 lines, -85 lines 0 comments Download
D content/renderer/media/peer_connection_handler_jsep.cc View 1 chunk +0 lines, -368 lines 0 comments Download
D content/renderer/media/peer_connection_handler_jsep_unittest.cc View 1 chunk +0 lines, -231 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +8 lines, -20 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
eugenis
8 years, 8 months ago (2012-04-12 10:07:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698