Enable UserDataDir selection in InProcessBrowserTest

Enable UserDataDir selection in InProcessBrowserTest

Changed InProcessBrowserTest to allow us to use SetUpCommandLine to specify a
UserDataDir via the kUserDataDir switch.  It appears this was intended in the original code, since CreateUserDataDirectory currently checks the commandline for the presence of kUserDataDir.

BUG=122883
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132347

[Devlin, 2012-04-11 23:42:45]

Quick fix to allow kUserDataDir to work in InProcessBrowserTest; passes win_rel,
linux_rel, and mac_rel.

[Yoyo Zhou, 2012-04-12 00:25:28]

https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/exte...
File chrome/browser/extensions/extension_browsertest.h (right):

https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/exte...
chrome/browser/extensions/extension_browsertest.h:31: virtual void
SetUpCommandLine(CommandLine* command_line) OVERRIDE;
SetUpUserDataDirectory should be here too.

[Devlin, 2012-04-12 00:37:10]

https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/exte...
File chrome/browser/extensions/extension_browsertest.h (right):

https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/exte...
chrome/browser/extensions/extension_browsertest.h:31: virtual void
SetUpCommandLine(CommandLine* command_line) OVERRIDE;
On 2012/04/12 00:25:28, Yoyo Zhou wrote:
> SetUpUserDataDirectory should be here too.

I can certainly add in the line, but why is it necessary? ExtensionBrowserTest
doesn't have any special implementation of SetUpUserDataDirectory, and we don't
usually include virtual functions we don't change...Am I just missing something
obvious?

[Yoyo Zhou, 2012-04-12 00:45:02]

LGTM but you might want a sanity check from Aaron too.

https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/exte...
File chrome/browser/extensions/extension_browsertest.h (right):

https://chromiumcodereview.appspot.com/10037023/diff/6001/chrome/browser/exte...
chrome/browser/extensions/extension_browsertest.h:31: virtual void
SetUpCommandLine(CommandLine* command_line) OVERRIDE;
On 2012/04/12 00:37:10, D Cronin wrote:
> On 2012/04/12 00:25:28, Yoyo Zhou wrote:
> > SetUpUserDataDirectory should be here too.
> 
> I can certainly add in the line, but why is it necessary? ExtensionBrowserTest
> doesn't have any special implementation of SetUpUserDataDirectory, and we
don't
> usually include virtual functions we don't change...Am I just missing
something
> obvious?
> 

Oops, I misread -- this .h file doesn't go with the
extension_startup_browsertest.cc.

[Aaron Boodman, 2012-04-12 04:27:28]

LGTM

[commit-bot: I haz the power, 2012-04-13 23:32:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10037023/1...

[commit-bot: I haz the power, 2012-04-14 01:20:04]

Try job failure for 10037023-11001 (retry) (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-14 16:52:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10037023/1...

[commit-bot: I haz the power, 2012-04-14 16:54:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10037023/1...

[commit-bot: I haz the power, 2012-04-14 19:22:47]

Change committed as 132347