Issue 10035060: Fix bug in forced-deletion of globals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10035060: Fix bug in forced-deletion of globals. (Closed)

Created:
8 years, 8 months ago by fschneider

Modified:
8 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix bug in forced-deletion of globals. When inling functions across contexts in optimized code and using ForceDelete from the API to delete a DontDelete global property we can end up returning the hole value instead of throwing a ReferenceError as expected after accessing a deleted global variable. BUG=v8:2092 TEST=test/cctest/test-api/InlinedFunctionAcrossContexts Committed: https://code.google.com/p/v8/source/detail?r=11396

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -4 lines)			Patch
	M	src/api.cc	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		2 chunks	+40 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages