Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: tests/standalone/src/io/Regress-1925.dart

Issue 10035056: Fix a number of editor errors and warnings in io tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/src/io/Regress-1925.dart
diff --git a/tests/standalone/src/io/Regress-1925.dart b/tests/standalone/src/io/Regress-1925.dart
index bbcf31e873b6467178135f14e8c17f5a84f12033..5c7c97695357a93cdd0ba970ea031e478e5c27bf 100644
--- a/tests/standalone/src/io/Regress-1925.dart
+++ b/tests/standalone/src/io/Regress-1925.dart
@@ -13,12 +13,10 @@
#import("dart:isolate");
#source("TestingServer.dart");
-final CONNECTIONS = 200;
-
class Regress1925TestServer extends TestingServer {
void onConnection(Socket socket) {
- socket.onError = () => Expect.fail("Server socket error");
+ socket.onError = (e) => Expect.fail("Server socket error $e");
socket.inputStream.onClosed = () => socket.outputStream.close();
socket.inputStream.onData = () {
var buffer = new List(1);
@@ -37,16 +35,6 @@ class Regress1925Test extends TestingServerTest {
void run() {
- void onConnect() {
- _connections++;
- if (_connections == CONNECTIONS) {
- for (int i = 0; i < CONNECTIONS; i++) {
- _sockets[i].close();
- }
- shutdown();
- }
- }
-
var count = 0;
var buffer = new List(5);
Socket socket = new Socket(TestingServer.HOST, _port);
@@ -60,7 +48,7 @@ class Regress1925Test extends TestingServerTest {
Expect.equals(5, count);
shutdown();
};
- socket.inputStream.onError = () => Expect.fail("Socket error");
+ socket.inputStream.onError = (e) => Expect.fail("Socket error $e");
};
}
}

Powered by Google App Engine
This is Rietveld 408576698