net/test/base_test_server.cc - Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/base_test_server.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Really fix Windows, address comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/test/base_test_server.cc

diff --git a/net/test/base_test_server.cc b/net/test/base_test_server.cc

index 533cb9d570e23a433b9b329f25d8778c082ddf70..07bef89744d1bc25dd473c6d806083b180b19a7a 100644

--- a/net/test/base_test_server.cc

+++ b/net/test/base_test_server.cc

@@ -256,7 +256,7 @@ void BaseTestServer::SetResourcePath(const FilePath& document_root,

bool BaseTestServer::ParseServerData(const std::string& server_data) {

VLOG(1) << "Server data: " << server_data;

base::JSONReader json_reader;

- scoped_ptr<Value> value(json_reader.JsonToValue(server_data, true, false));

+ scoped_ptr<Value> value(json_reader.ReadToValue(server_data));

if (!value.get() || !value->IsType(Value::TYPE_DICTIONARY)) {

LOG(ERROR) << "Could not parse server data: "

<< json_reader.GetErrorMessage();

« no previous file with comments | « chrome/test/base/ui_test_utils.cc ('k') | net/test/spawner_communicator.cc » ('j') | no next file with comments »