Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Really fix Windows, address comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values.cc ('k') | chrome/browser/extensions/settings/settings_leveldb_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index 1f859424313f20730b6f23b03eafcea15574eb13..cd1b0e10ee1dda864a72e402b225a35997cdc13a 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -2142,10 +2142,8 @@ void TestingAutomationProvider::GetBlockedPopupCount(int handle, int* count) {
void TestingAutomationProvider::SendJSONRequest(int handle,
const std::string& json_request,
IPC::Message* reply_message) {
- scoped_ptr<Value> values;
- base::JSONReader reader;
std::string error;
- values.reset(reader.ReadAndReturnError(json_request,
+ scoped_ptr<Value> values(base::JSONReader::ReadAndReturnError(json_request,
base::JSON_ALLOW_TRAILING_COMMAS, NULL, &error));
if (!error.empty()) {
AutomationJSONReply(this, reply_message).SendError(error);
« no previous file with comments | « base/values.cc ('k') | chrome/browser/extensions/settings/settings_leveldb_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698