base/debug/trace_event_unittest.cc - Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/trace_event_unittest.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Really fix Windows, address comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/trace_event_unittest.cc

diff --git a/base/debug/trace_event_unittest.cc b/base/debug/trace_event_unittest.cc

index 66dff0d7f7d57819aa45fcd30f7f8c21ff4462d6..f839d274698b5cc724ad249341fed27f5c6da51b 100644

--- a/base/debug/trace_event_unittest.cc

+++ b/base/debug/trace_event_unittest.cc

@@ -99,7 +99,8 @@ void TraceEventTestFixture::OnTraceDataCollected(

trace_buffer_.Finish();

scoped_ptr<Value> root;

- root.reset(base::JSONReader::Read(json_output_.json_output));

+ root.reset(base::JSONReader::Read(json_output_.json_output,

+ JSON_PARSE_RFC | JSON_DETACHABLE_CHILDREN));

if (!root.get()) {

LOG(ERROR) << json_output_.json_output;

« no previous file with comments | « base/base_export.h ('k') | base/json/json_parser.h » ('j') | no next file with comments »