Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/prefs/pref_model_associator.cc

Issue 10035042: Rewrite base::JSONReader to be 35-40% faster, depending on the input string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_model_associator.cc
diff --git a/chrome/browser/prefs/pref_model_associator.cc b/chrome/browser/prefs/pref_model_associator.cc
index b70302a825f0e87aa57f4a4ec31bbe639ae8cbc1..abb419bb46a0ffdb0f86816bb7ca71f4e61c0f9c 100644
--- a/chrome/browser/prefs/pref_model_associator.cc
+++ b/chrome/browser/prefs/pref_model_associator.cc
@@ -48,8 +48,7 @@ void PrefModelAssociator::InitPrefAndAssociate(
sync_pref.GetSpecifics().preference();
DCHECK_EQ(pref->name(), preference.name());
- scoped_ptr<Value> value(
- reader.JsonToValue(preference.value(), false, false));
+ scoped_ptr<Value> value(reader.ReadToValue(preference.value()));
if (!value.get()) {
LOG(ERROR) << "Failed to deserialize preference value: "
<< reader.GetErrorMessage();
@@ -350,7 +349,7 @@ Value* PrefModelAssociator::ReadPreferenceSpecifics(
const sync_pb::PreferenceSpecifics& preference,
std::string* name) {
base::JSONReader reader;
- scoped_ptr<Value> value(reader.JsonToValue(preference.value(), false, false));
+ scoped_ptr<Value> value(reader.ReadToValue(preference.value()));
if (!value.get()) {
std::string err = "Failed to deserialize preference value: " +
reader.GetErrorMessage();

Powered by Google App Engine
This is Rietveld 408576698