Rewrite base::JSONReader to be 35-40% faster, depending on the input string.

chrome/installer/util/master_preferences_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Unit tests for master preferences related methods.
 
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/stringprintf.h"
@@ skipping 50 matching lines @@
     "     \"require_eula\": true,\n"
     "     \"alternate_shortcut_text\": true,\n"
     "     \"chrome_shortcut_icon_index\": 1,\n"
     "     \"ping_delay\": 40\n"
     "  },\n"
     "  \"blah\": {\n"
     "     \"import_history\": false\n"
     "  }\n"
     "} \n";
 
-  EXPECT_TRUE(file_util::WriteFile(prefs_file(), text, sizeof(text)));
+  EXPECT_TRUE(file_util::WriteFile(prefs_file(), text, strlen(text)));
   installer::MasterPreferences prefs(prefs_file());
 
   const char* expected_true[] = {
     installer::master_preferences::kDistroSkipFirstRunPref,
     installer::master_preferences::kDistroShowWelcomePage,
     installer::master_preferences::kDistroImportSearchPref,
     installer::master_preferences::kDistroImportHistoryPref,
     installer::master_preferences::kDistroImportBookmarksPref,
     installer::master_preferences::kDistroImportHomePagePref,
     installer::master_preferences::kCreateAllShortcuts,
@@ skipping 36 matching lines @@
     "     \"skip_first_run_ui\": true,\n"
     "     \"import_search_engine\": true,\n"
     "     \"import_bookmarks\": false,\n"
     "     \"import_bookmarks_from_file\": \"\",\n"
     "     \"create_all_shortcuts\": true,\n"
     "     \"do_not_launch_chrome\": true,\n"
     "     \"chrome_shortcut_icon_index\": \"bac\"\n"
     "  }\n"
     "} \n";
 
-  EXPECT_TRUE(file_util::WriteFile(prefs_file(), text, sizeof(text)));
+  EXPECT_TRUE(file_util::WriteFile(prefs_file(), text, strlen(text)));
   installer::MasterPreferences prefs(prefs_file());
 
   ExpectedBooleans expected_bool[] = {
     { installer::master_preferences::kDistroSkipFirstRunPref, true },
     { installer::master_preferences::kDistroImportSearchPref, true },
     { installer::master_preferences::kDistroImportBookmarksPref, false },
     { installer::master_preferences::kCreateAllShortcuts, true },
     { installer::master_preferences::kDoNotLaunchChrome, true },
   };
 
@@ skipping 39 matching lines @@
     "  \"distribution\": { \n"
     "     \"something here\": true\n"
     "  },\n"
     "  \"first_run_tabs\": [\n"
     "     \"http://google.com/f1\",\n"
     "     \"https://google.com/f2\",\n"
     "     \"new_tab_page\"\n"
     "  ]\n"
     "} \n";
 
-  EXPECT_TRUE(file_util::WriteFile(prefs_file(), text, sizeof(text)));
+  EXPECT_TRUE(file_util::WriteFile(prefs_file(), text, strlen(text)));
   installer::MasterPreferences prefs(prefs_file());
   typedef std::vector<GURL> TabsVector;
   TabsVector tabs = prefs.GetFirstRunTabs();
   ASSERT_EQ(3, tabs.size());
   EXPECT_EQ(GURL("http://google.com/f1"), tabs[0]);
   EXPECT_EQ(GURL("https://google.com/f2"), tabs[1]);
   EXPECT_EQ(GURL("new_tab_page"), tabs[2]);
 }
 
 // In this test instead of using our synthetic json file, we use an
@@ skipping 37 matching lines @@
   const char text[] =
     "{ \n"
     "  \"distribution\": { \n"
     "     \"skip_first_run_ui\": true,\n"
     "     \"create_all_shortcuts\": false,\n"
     "     \"do_not_launch_chrome\": true,\n"
     "     \"system_level\": true,\n"
     "     \"verbose_logging\": false\n"
     "  }\n"
     "} \n";
-  EXPECT_TRUE(file_util::WriteFile(prefs_file, text, sizeof(text)));
+  EXPECT_TRUE(file_util::WriteFile(prefs_file, text, strlen(text)));
 
   // Make sure command line values override the values in master preferences.
   std::wstring cmd_str(
       L"setup.exe --installerdata=\"" + prefs_file.value() + L"\"");
   cmd_str.append(L" --create-all-shortcuts");
   cmd_str.append(L" --do-not-launch-chrome");
   cmd_str.append(L" --alt-desktop-shortcut");
   CommandLine cmd_line = CommandLine::FromString(cmd_str);
   installer::MasterPreferences prefs(cmd_line);
 
@@ skipping 86 matching lines @@
 
   EXPECT_TRUE(pref_cf.is_multi_install());
   EXPECT_FALSE(pref_cf.install_chrome());
   EXPECT_TRUE(pref_cf.install_chrome_frame());
 
   EXPECT_TRUE(pref_chrome_cf.is_multi_install());
   EXPECT_TRUE(pref_chrome_cf.install_chrome());
   EXPECT_TRUE(pref_chrome_cf.install_chrome_frame());
 }