Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10035032: Give a sourceElement to SSA instructions so that if they end up being 'define' in the codegen (ie n… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/builder.dart
===================================================================
--- lib/compiler/implementation/ssa/builder.dart (revision 6688)
+++ lib/compiler/implementation/ssa/builder.dart (working copy)
@@ -529,7 +529,7 @@
void endLoop(HBasicBlock loopEntry) {
loopEntry.forEachPhi((HPhi phi) {
- Element element = phi.element;
+ Element element = phi.sourceElement;
HInstruction postLoopDefinition = directLocals[element];
phi.addInput(postLoopDefinition);
});
@@ -1736,6 +1736,10 @@
} else {
localsHandler.updateLocal(element, value);
stack.add(value);
+ // If the value does not already have a name, give it here.
+ if (value.sourceElement === null) {
+ value.sourceElement = element;
+ }
}
}
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698