Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issue 10035021: Reduce size of LIR instruction by one word and remove dead code. (Closed)

Created:
8 years, 8 months ago by fschneider
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reduce size of LIR instruction by one word and remove dead code. Until now we always recorded two deoptimization environments for instructions that are marked as calls. We actually don't need two for all LIR instructions except one (LInstanceOfKnownGlobal) where there is a lazy deoptimization point in deferred code. This change remove on of them and uses one virtual function instead to make LInstanceOfKnownGlobal work as before. Additionally, this change removes an unused predicate save_doubles_ from LIR instructions and removes some helper functions that are used only in one place. Committed: https://code.google.com/p/v8/source/detail?r=11454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -203 lines) Patch
M src/arm/lithium-arm.h View 5 chunks +11 lines, -20 lines 0 comments Download
M src/arm/lithium-arm.cc View 4 chunks +9 lines, -26 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.h View 5 chunks +11 lines, -20 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 4 chunks +9 lines, -26 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 5 chunks +11 lines, -19 lines 0 comments Download
M src/mips/lithium-mips.cc View 4 chunks +9 lines, -26 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.h View 5 chunks +12 lines, -21 lines 0 comments Download
M src/x64/lithium-x64.cc View 4 chunks +9 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
8 years, 8 months ago (2012-04-18 10:49:09 UTC) #1
fschneider
redirecting to vegorov.
8 years, 8 months ago (2012-04-26 11:22:19 UTC) #2
Vyacheslav Egorov (Chromium)
8 years, 8 months ago (2012-04-26 11:42:07 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698