Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 10035008: Merge 132638 - aura/texture transport: Keep ref to texture infos to avoid races with the UI (Closed)

Created:
8 years, 8 months ago by ddrew
Modified:
8 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Merge 132638 - aura/texture transport: Keep ref to texture infos to avoid races with the UI In some cases, the UI may destroy the textures the renderer is rendering into before the renderer has a chance to finish. This patch makes it so that we avoid generating a lost context event in the page that is closing, because we can't recover correctly in the other pages in the same renderer process. This also adds logging so that we can audit all cases of lost context. BUG=122868 TEST=run aura chrome, open and close tabs (from the same process), observe no flashing and no mention of a lost context. Review URL: http://codereview.chromium.org/10103021 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -59 lines) Patch
M content/common/gpu/texture_image_transport_surface.h View 4 chunks +6 lines, -4 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 12 chunks +69 lines, -51 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ddrew
8 years, 8 months ago (2012-04-17 21:19:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698