Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 10034031: modified Run button to always run the last launched application (Closed)

Created:
8 years, 8 months ago by keertip
Modified:
8 years, 8 months ago
Reviewers:
devoncarew, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

modified Run button to always run the last launched application Committed: https://code.google.com/p/dart/source/detail?r=6537

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 1

Messages

Total messages: 6 (0 generated)
keertip
The toolbar Run button, Tools > Run and shortcut Ctrl/Cmd + R option now launch ...
8 years, 8 months ago (2012-04-11 22:24:27 UTC) #1
devoncarew
lgtm Looks good, though I think we should include a 'Run selected' menu item in ...
8 years, 8 months ago (2012-04-11 22:29:39 UTC) #2
keertip
PTAL, have added tools menu item + keybinding to run selection
8 years, 8 months ago (2012-04-13 16:34:42 UTC) #3
devoncarew
lgtm Looks good, w/ some variable + command id rename suggestions. https://chromiumcodereview.appspot.com/10034031/diff/4001/editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml File editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml (right): ...
8 years, 8 months ago (2012-04-13 16:41:54 UTC) #4
keertip
https://chromiumcodereview.appspot.com/10034031/diff/4001/editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml File editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml (right): https://chromiumcodereview.appspot.com/10034031/diff/4001/editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml#newcode63 editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml:63: commandId="com.google.dart.tools.debug.ui.run" On 2012/04/13 16:41:54, devoncarew wrote: > Should we ...
8 years, 8 months ago (2012-04-13 16:52:24 UTC) #5
danrubel
8 years, 8 months ago (2012-04-13 18:24:32 UTC) #6
lgtm

https://chromiumcodereview.appspot.com/10034031/diff/4002/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/deploy/ApplicationActionBarAdvisor.java
(right):

https://chromiumcodereview.appspot.com/10034031/diff/4002/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/deploy/ApplicationActionBarAdvisor.java:470:
dartRunLastAction = new DartRunLastAction(window);
setText and setToolTipText similar to below?
or are those set elsewhere?

Powered by Google App Engine
This is Rietveld 408576698