Issue 10034010: Fix WeakMap processing for evacuation candidates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10034010: Fix WeakMap processing for evacuation candidates. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix WeakMap processing for evacuation candidates. This fixes processing of WeakMaps so that value entries on an evacuation candidate are correctly recorded in the slots buffer. We didn't pass the correct slot into the backing hashtable while visiting values. Also the live bytes counter for large object space pages was not reset correctly when incremental marking is aborted. R=vegorov@chromium.org BUG=v8:2060 TEST=cctest/test-weakmaps/Regress2060 Committed: https://code.google.com/p/v8/source/detail?r=11264

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -10 lines)			Patch
	M	src/mark-compact.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
	M	test/cctest/test-weakmaps.cc	View		4 chunks	+39 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages