Issue 10034009: chrome/browser/chromeos/input_method/ refactoring [part 3 of 6].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10034009: chrome/browser/chromeos/input_method/ refactoring [part 3 of 6]. (Closed)

Created:
8 years, 8 months ago by Yusuke Sato

Modified:
8 years, 8 months ago

Reviewers:
kinaba

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, Seigo Nonaka

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome/browser/chromeos/input_method/ refactoring [part 3 of 6]. Add a mock implementation of the chromeos::input_method::CandidateWindowController interface. This is for http://codereview.chromium.org/9999018/. BUG=chromium-os:19655 TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131973

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -0 lines)			Patch
A	chrome/browser/chromeos/input_method/mock_candidate_window.h	View	1 chunk	+44 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/input_method/mock_candidate_window.cc	View	1 chunk	+47 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 8 months ago (2012-04-12 13:16:42 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10034009/1

Expand Messages | Collapse Messages