Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 10033028: Reland arguments access support for inlined functions (r11109,r11118). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix Kevin's comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1053 matching lines...) Expand 10 before | Expand all | Expand 10 after
1064 return new(zone()) LCmpMapAndBranch(value); 1064 return new(zone()) LCmpMapAndBranch(value);
1065 } 1065 }
1066 1066
1067 1067
1068 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) { 1068 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) {
1069 return DefineAsRegister(new(zone()) LArgumentsLength(Use(length->value()))); 1069 return DefineAsRegister(new(zone()) LArgumentsLength(Use(length->value())));
1070 } 1070 }
1071 1071
1072 1072
1073 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) { 1073 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) {
1074 return DefineAsRegister(new(zone()) LArgumentsElements); 1074 return DefineAsRegister(new(zone()) LArgumentsElements(
1075 elems->from_inlined()));
1075 } 1076 }
1076 1077
1077 1078
1078 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) { 1079 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) {
1079 LOperand* left = UseFixed(instr->left(), rax); 1080 LOperand* left = UseFixed(instr->left(), rax);
1080 LOperand* right = UseFixed(instr->right(), rdx); 1081 LOperand* right = UseFixed(instr->right(), rdx);
1081 LInstanceOf* result = new(zone()) LInstanceOf(left, right); 1082 LInstanceOf* result = new(zone()) LInstanceOf(left, right);
1082 return MarkAsCall(DefineFixed(result, rax), instr); 1083 return MarkAsCall(DefineFixed(result, rax), instr);
1083 } 1084 }
1084 1085
(...skipping 1178 matching lines...) Expand 10 before | Expand all | Expand 10 after
2263 2264
2264 LInstruction* LChunkBuilder::DoEnterInlined(HEnterInlined* instr) { 2265 LInstruction* LChunkBuilder::DoEnterInlined(HEnterInlined* instr) {
2265 HEnvironment* outer = current_block_->last_environment(); 2266 HEnvironment* outer = current_block_->last_environment();
2266 HConstant* undefined = graph()->GetConstantUndefined(); 2267 HConstant* undefined = graph()->GetConstantUndefined();
2267 HEnvironment* inner = outer->CopyForInlining(instr->closure(), 2268 HEnvironment* inner = outer->CopyForInlining(instr->closure(),
2268 instr->arguments_count(), 2269 instr->arguments_count(),
2269 instr->function(), 2270 instr->function(),
2270 undefined, 2271 undefined,
2271 instr->call_kind(), 2272 instr->call_kind(),
2272 instr->is_construct()); 2273 instr->is_construct());
2273 if (instr->arguments() != NULL) { 2274 if (instr->arguments_var() != NULL) {
2274 inner->Bind(instr->arguments(), graph()->GetArgumentsObject()); 2275 inner->Bind(instr->arguments_var(), graph()->GetArgumentsObject());
2275 } 2276 }
2276 current_block_->UpdateEnvironment(inner); 2277 current_block_->UpdateEnvironment(inner);
2277 chunk_->AddInlinedClosure(instr->closure()); 2278 chunk_->AddInlinedClosure(instr->closure());
2278 return NULL; 2279 return NULL;
2279 } 2280 }
2280 2281
2281 2282
2282 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 2283 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
2284 LInstruction* pop = NULL;
2285
2286 HEnvironment* env = current_block_->last_environment();
2287
2288 if (instr->arguments_pushed()) {
2289 int argument_count = env->arguments_environment()->parameter_count();
2290 pop = new(zone()) LDrop(argument_count);
2291 argument_count_ -= argument_count;
2292 }
2293
2283 HEnvironment* outer = current_block_->last_environment()-> 2294 HEnvironment* outer = current_block_->last_environment()->
2284 DiscardInlined(false); 2295 DiscardInlined(false);
2285 current_block_->UpdateEnvironment(outer); 2296 current_block_->UpdateEnvironment(outer);
2286 return NULL; 2297
2298 return pop;
2287 } 2299 }
2288 2300
2289 2301
2290 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2302 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2291 LOperand* key = UseOrConstantAtStart(instr->key()); 2303 LOperand* key = UseOrConstantAtStart(instr->key());
2292 LOperand* object = UseOrConstantAtStart(instr->object()); 2304 LOperand* object = UseOrConstantAtStart(instr->object());
2293 LIn* result = new(zone()) LIn(key, object); 2305 LIn* result = new(zone()) LIn(key, object);
2294 return MarkAsCall(DefineFixed(result, rax), instr); 2306 return MarkAsCall(DefineFixed(result, rax), instr);
2295 } 2307 }
2296 2308
(...skipping 22 matching lines...) Expand all
2319 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2331 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2320 LOperand* object = UseRegister(instr->object()); 2332 LOperand* object = UseRegister(instr->object());
2321 LOperand* index = UseTempRegister(instr->index()); 2333 LOperand* index = UseTempRegister(instr->index());
2322 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2334 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2323 } 2335 }
2324 2336
2325 2337
2326 } } // namespace v8::internal 2338 } } // namespace v8::internal
2327 2339
2328 #endif // V8_TARGET_ARCH_X64 2340 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698