Fix bug in HTTP header parsing

tests/standalone/src/io/HttpParserTest.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #source("../../../../runtime/bin/http_parser.dart");
 
 class HttpParserTest {
   static void runAllTests() {
     testParseRequest();
     testParseResponse();
@@ skipping 282 matching lines @@
 X-Header-B: bbb\r
 \r
 """;
     headers = new Map();
     headers["header-a"] = "AAA";
     headers["x-header-b"] = "bbb";
     _testParseRequest(request, "POST", "/test", expectedHeaders: headers);
 
     request = """
 POST /test HTTP/1.1\r
+Empty-Header-1:\r
+Empty-Header-2:\r
+        \r
+\r
+""";
+    headers = new Map();
+    headers["empty-header-1"] = "";
+    headers["empty-header-2"] = "";
+    _testParseRequest(request, "POST", "/test", expectedHeaders: headers);
+
+    request = """
+POST /test HTTP/1.1\r
 Header-A:   AAA\r
 X-Header-B:\t \t bbb\r
 \r
 """;
     headers = new Map();
     headers["header-a"] = "AAA";
     headers["x-header-b"] = "bbb";
     _testParseRequest(request, "POST", "/test", expectedHeaders: headers);
 
     request = """
@@ skipping 250 matching lines @@
 
     request = "@ / HTTP/1.1\r\n\r\n";
     _testParseInvalidRequest(request);
 
     request = "GET / TTP/1.1\r\n\r\n";
     _testParseInvalidRequest(request);
 
     request = "GET / HTTP/1.\r\n\r\n";
     _testParseInvalidRequest(request);
 
+    request = "GET / HTTP/1.1\r\nKeep-Alive: False\r\nbadheader\r\n\r\n";
+    _testParseInvalidRequest(request);
+
     // Currently no HTTP 1.0 support.
     request = "GET / HTTP/1.0\r\n\r\n";
     _testParseInvalidRequest(request);
-
-    Expect.throws(() {
-      // TODO(2370): HTTP parser error.
-      request = "GET / HTTP/1.1\r\nKeep-Alive: False\r\nbadheader\r\n\r\n";
-      _testParseInvalidRequest(request);
-    });
   }
 
   static void testParseInvalidResponse() {
     String response;
 
     response = "HTTP/1.1\r\nContent-Length: 0\r\n\r\n";
     _testParseInvalidResponse(response);
 
     response = "HTTP/1.1 \r\nContent-Length: 0\r\n\r\n";
     _testParseInvalidResponse(response);
@@ skipping 18 matching lines @@
 
     response = "HTTP/1.1 000 OK\r\nContent-Length: 0\r\n\r\n";
     _testParseInvalidResponse(response);
 
     response = "HTTP/1.1 999 Server Error\r\nContent-Length: 0\r\n\r\n";
     _testParseInvalidResponse(response);
 
     response = "HTTP/1.1 200 OK\r\nContent-Length: x\r\n\r\n";
     _testParseInvalidResponse(response);
 
+    response = "HTTP/1.1 200 OK\r\nbadheader\r\n\r\n";
+    _testParseInvalidResponse(response);
+
     response = """
 HTTP/1.1 200 OK\r
 Transfer-Encoding: chunked\r
 \r
 1A\r
 01234567890123456789012345\r
 1g\r
 0123456789012345678901234567890\r
 0\r\n\r\n""";
     _testParseInvalidResponse(response);
   }
 }
 
 
 void main() {
   HttpParserTest.runAllTests();
 }