Convert printing ui_tests to browser_tests.

Convert printing ui_tests to browser_tests.

BUG=121574
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131436

[Lei Zhang, 2012-04-09 19:44:44]

http://codereview.chromium.org/10033001/diff/1/chrome/browser/automation/auto...
File chrome/browser/automation/automation_provider_observers.cc (left):

http://codereview.chromium.org/10033001/diff/1/chrome/browser/automation/auto...
chrome/browser/automation/automation_provider_observers.cc:1285:
DocumentPrintedNotificationObserver::DocumentPrintedNotificationObserver(
Remove from automation_provider_observers.h as well?

http://codereview.chromium.org/10033001/diff/1/chrome/browser/automation/test...
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/10033001/diff/1/chrome/browser/automation/test...
chrome/browser/automation/testing_automation_provider.cc:76: #include
"chrome/browser/printing/print_view_manager.h"
You can also get rid of this #include.

http://codereview.chromium.org/10033001/diff/1/chrome/browser/printing/printi...
File chrome/browser/printing/printing_layout_browsertest.cc (right):

http://codereview.chromium.org/10033001/diff/1/chrome/browser/printing/printi...
chrome/browser/printing/printing_layout_browsertest.cc:67: content::WebContents*
web_contents = browser()->GetSelectedWebContents();
Just call browser()->GetSelectedTabContentsWrapper() instead?

http://codereview.chromium.org/10033001/diff/1/chrome/browser/printing/printi...
chrome/browser/printing/printing_layout_browsertest.cc:121:
FilePath().AppendASCII("printing"), FilePath()));
FilePath().AppendASCII("printing") -> FilePath(L"printing") ?

http://codereview.chromium.org/10033001/diff/1/chrome/common/automation_messa...
File chrome/common/automation_messages_internal.h (right):

http://codereview.chromium.org/10033001/diff/1/chrome/common/automation_messa...
chrome/common/automation_messages_internal.h:617:
IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_DEPRECATED_PrintNow,
I'm curious why this isn't removed, when all other references to it in C++ code
are deleted in this CL.

[jam, 2012-04-09 20:16:22]

http://codereview.chromium.org/10033001/diff/1/chrome/browser/automation/auto...
File chrome/browser/automation/automation_provider_observers.cc (left):

http://codereview.chromium.org/10033001/diff/1/chrome/browser/automation/auto...
chrome/browser/automation/automation_provider_observers.cc:1285:
DocumentPrintedNotificationObserver::DocumentPrintedNotificationObserver(
On 2012/04/09 19:44:44, Lei Zhang wrote:
> Remove from automation_provider_observers.h as well?

oops, forgot to include that file in my change :)

http://codereview.chromium.org/10033001/diff/1/chrome/browser/automation/test...
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/10033001/diff/1/chrome/browser/automation/test...
chrome/browser/automation/testing_automation_provider.cc:76: #include
"chrome/browser/printing/print_view_manager.h"
On 2012/04/09 19:44:44, Lei Zhang wrote:
> You can also get rid of this #include.

Done.

http://codereview.chromium.org/10033001/diff/1/chrome/browser/printing/printi...
File chrome/browser/printing/printing_layout_browsertest.cc (right):

http://codereview.chromium.org/10033001/diff/1/chrome/browser/printing/printi...
chrome/browser/printing/printing_layout_browsertest.cc:67: content::WebContents*
web_contents = browser()->GetSelectedWebContents();
On 2012/04/09 19:44:44, Lei Zhang wrote:
> Just call browser()->GetSelectedTabContentsWrapper() instead?

Done.

http://codereview.chromium.org/10033001/diff/1/chrome/browser/printing/printi...
chrome/browser/printing/printing_layout_browsertest.cc:121:
FilePath().AppendASCII("printing"), FilePath()));
On 2012/04/09 19:44:44, Lei Zhang wrote:
> FilePath().AppendASCII("printing") -> FilePath(L"printing") ?

I didn't do it that way because that would make porting the test to non-windows
more work

http://codereview.chromium.org/10033001/diff/1/chrome/common/automation_messa...
File chrome/common/automation_messages_internal.h (right):

http://codereview.chromium.org/10033001/diff/1/chrome/common/automation_messa...
chrome/common/automation_messages_internal.h:617:
IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_DEPRECATED_PrintNow,
On 2012/04/09 19:44:44, Lei Zhang wrote:
> I'm curious why this isn't removed, when all other references to it in C++
code
> are deleted in this CL.

because then the ipc id's change and the reference builds have to be updated

[Lei Zhang, 2012-04-09 20:59:58]

lgtm