Issue 10031050: Make idle logout window not cause the app list to disappear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10031050: Make idle logout window not cause the app list to disappear. (Closed)

Created:
8 years, 8 months ago by rkc

Modified:
8 years, 8 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make idle logout window not cause the app list to disappear. When the app list is up, create the idle logout window as a child of the app list. This way the idle logout window will still always be on top but will not cause the app list to disappear. R=xiyuan@chromium.org BUG=chromium-os:28683 TEST=Tested that the window comes up on top of the app list and goes away; both without causing the app list window to be disturbed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131706

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/ui/idle_logout_dialog_view.cc	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10031050/1

8 years, 8 months ago (2012-04-10 23:13:42 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-11 01:37:28 UTC) #4

Try job failure for 10031050-1 (retry) on win_rel for step "browser_tests"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages